1549843 - Implement jitter reduction performance tweaks on Motorola G5

Status: RESOLVED FIXED

(Testing :: General, enhancement)

Description

[Edwin Takahashi (:egao | infrequent contributor)]

The patch put up at Bug #1547135 has been scope-restricted to deal with only Pixel 2.

Motorola G5 has a slightly different path for some of its files; these need to be taken into account.

This try push (https://hg.mozilla.org/try/rev/66481b83cc8d3613baced5dcd8608685f1b9eace) contains most of the correct paths for Motorola G5.

Todos:

1. adapt paths (mostly done in https://hg.mozilla.org/try/rev/66481b83cc8d3613baced5dcd8608685f1b9eace)
2. run a barrage of tests to verify performance/noise improvement

Comment 1

[Edwin Takahashi (:egao | infrequent contributor)]

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&searchStr=tp6m&revision=e63ac3728fe5c14ba4e092408e7a144911228b8c&selectedJob=245609315

Tests were successfully run on Motorola G5 devices. Proceeding to run 25 instances of all tp6m-geckoview tests to obtain a baseline comparison against 626d8adc3162d8ed59571d143812ea5f0ec2166f.

Comment 2

[Edwin Takahashi (:egao | infrequent contributor)]

Attachment: Bug 1549843 - implement jitter reduction for Motorola G5

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1af537f969cb
implement jitter reduction for Motorola G5 r=jmaher,rwood

Comment 4

[Edwin Takahashi (:egao | infrequent contributor)]

Perfherder comparison:
https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=626d8adc3162d8ed59571d143812ea5f0ec2166f&newProject=try&newRevision=e63ac3728fe5c14ba4e092408e7a144911228b8c&framework=10

Baseline revision is same as used in the Google Pixel 2 comparison in bug #1547135.

metrics

Overall, noise mean value is -20% compared to baseline value, but noise has increased somewhat from 1.79 to 2.24.

Half the tests sampled show decrease in noise metric (desirable).

Some tests show minor increase in noise metric.

A handful of tests show significantly increase noise metric (not desirable). These need to be investigated further.

Overall, the clustering of test results have improved in this revision. This can partially explain the increase in noise metric for some tests, since one or two outliers in the otherwise tightly clustered results would throw off the deviation values.

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/1af537f969cb

Comment 6

[Ionuț Goldan [:igoldan]]

== Change summary for alert #20917 (as of Sat, 11 May 2019 16:10:16 GMT) ==

Improvements:

14% raptor-tp6m-google-geckoview-cold fcp android-hw-g5-7-0-arm7-api-16 pgo 626.46 -> 540.71
13% raptor-tp6m-google-geckoview-cold fcp android-hw-g5-7-0-arm7-api-16 opt 643.92 -> 557.67
13% raptor-tp6m-google-geckoview-cold android-hw-g5-7-0-arm7-api-16 pgo 624.46 -> 544.53
13% raptor-tp6m-bing-geckoview-cold fcp android-hw-g5-7-0-arm7-api-16 opt 665.67 -> 582.25
12% raptor-tp6m-google-geckoview-cold loadtime android-hw-g5-7-0-arm7-api-16 pgo 1,137.17 -> 995.08
12% raptor-tp6m-google-geckoview-cold android-hw-g5-7-0-arm7-api-16 opt 643.06 -> 564.39
12% raptor-tp6m-bing-geckoview-cold android-hw-g5-7-0-arm7-api-16 opt 587.24 -> 515.92
12% raptor-tp6m-amazon-geckoview-cold android-hw-g5-7-0-arm7-api-16 opt 1,167.03 -> 1,028.54
11% raptor-tp6m-bing-geckoview-cold loadtime android-hw-g5-7-0-arm7-api-16 opt 587.83 -> 522.33
11% raptor-tp6m-google-geckoview-cold loadtime android-hw-g5-7-0-arm7-api-16 opt 1,166.83 -> 1,038.33
9% raptor-tp6m-youtube-geckoview-cold android-hw-g5-7-0-arm7-api-16 pgo 832.36 -> 756.58
8% raptor-tp6m-youtube-geckoview-cold android-hw-g5-7-0-arm7-api-16 opt 854.59 -> 789.34
8% raptor-tp6m-youtube-geckoview-cold loadtime android-hw-g5-7-0-arm7-api-16 pgo 1,410.12 -> 1,303.92
7% raptor-tp6m-youtube-geckoview-cold fcp android-hw-g5-7-0-arm7-api-16 pgo 874.08 -> 810.17
7% raptor-tp6m-youtube-geckoview-cold fcp android-hw-g5-7-0-arm7-api-16 opt 901.83 -> 843.12
6% raptor-tp6m-youtube-geckoview-cold loadtime android-hw-g5-7-0-arm7-api-16 opt 1,448.60 -> 1,357.79

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=20917