Open Bug 1549892 Opened 4 months ago Updated 3 months ago

Consistently use same macro to disable AV1 on Android

Categories

(Core :: Audio/Video: Playback, defect, P3)

Unspecified
Android
defect

Tracking

()

Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 --- fix-optional
firefox68 --- affected

People

(Reporter: jbeich, Unassigned, NeedInfo)

References

(Regression)

Details

Attachments

(1 file)

Attached patch v0Splinter Review

Android only pre-defines ANDROID but it seems Gecko converged on ANDROID. Nothing uses Android macro.

$ clang++80 -target armv7-none-linux-androideabi -dM -E -</dev/null | fgrep -i android
#define ANDROID 1

https://searchfox.org/mozilla-central/search?q=(ifdef%7Cdefine).*%5CbAndroid%5Cb&case=true&regexp=true&path=*.%7Bcpp%2Ch%7D

Before bug 1538474 media.av1.enabled was true on Android but not media.av1.use-dav1d. And bug 1536126 will disable RDD on Android which may affect security.

media.av1.enabled and media.av1.use-dav1d default to false in 67.0b18 and 68.0a1 (2019-05-07) builds for android-api-16. So, probably only a cosmetic/style issue.

Priority: -- → P3
Attachment #9063394 - Flags: review+

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jbeich, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(jbeich)
You need to log in before you can comment on or make changes to this bug.