Closed
Bug 1549906
Opened 5 years ago
Closed 5 years ago
Use brandings.ftl to allow OnboardingMessageProvider.jsm to use new strings
Categories
(Firefox :: Messaging System, enhancement, P1)
Firefox
Messaging System
Tracking
()
People
(Reporter: Mardak, Assigned: Mardak)
References
Details
Attachments
(1 file)
OnboardingMessageProvider doesn't actually use brandings.ftl strings added in bug 1547016, but we can make it seem like it does to avoid all_files_referenced whitelist to simplify uplift to 67.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Looks like the underlying issue is kinda related to something we ran into before. Specifically, urls = line.match(/[a-z0-9_\/-]+\.ftl/i); matches the first ".ftl" on a line but our bundle.js has multiple on a single line. More generally, the line matching logic looks for chrome then if no match try resource then if no match try .ftl, etc. And this prevents matching multiple mixed types of references on a single line.
Pushed by elee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d851ba3d3b29 Use brandings.ftl to allow OnboardingMessageProvider.jsm to use new strings r=flod
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
|
|
Assignee | |
Comment 6•5 years ago
|
||
Marking verified as per bug 1550098 Comment 13 for bugs that were status-firefox68=verified
status-firefox67:
--- → verified
|
|
Assignee | |
Updated•5 years ago
|
Component: Activity Streams: Newtab → Messaging System
You need to log in
before you can comment on or make changes to this bug.
Description
•