Closed Bug 1549906 Opened 6 months ago Closed 6 months ago

Use brandings.ftl to allow OnboardingMessageProvider.jsm to use new strings

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 68
Iteration:
68.4 - Apr 29 - May 12
Tracking Status
firefox67 --- verified
firefox68 --- verified

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

Attachments

(1 file)

OnboardingMessageProvider doesn't actually use brandings.ftl strings added in bug 1547016, but we can make it seem like it does to avoid all_files_referenced whitelist to simplify uplift to 67.

Looks like the underlying issue is kinda related to something we ran into before. Specifically, urls = line.match(/[a-z0-9_\/-]+\.ftl/i); matches the first ".ftl" on a line but our bundle.js has multiple on a single line. More generally, the line matching logic looks for chrome then if no match try resource then if no match try .ftl, etc. And this prevents matching multiple mixed types of references on a single line.

Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d851ba3d3b29
Use brandings.ftl to allow OnboardingMessageProvider.jsm to use new strings r=flod
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Blocks: 1550098

Internal test fix

Status: RESOLVED → VERIFIED

Marking verified as per bug 1550098 Comment 13 for bugs that were status-firefox68=verified

Component: Activity Streams: Newtab → Messaging System
You need to log in before you can comment on or make changes to this bug.