1549931 - The tree column picker menu from the Saved Logins dialog box is wrongly displayed if opened twice

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect, P1)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: Saved Logins.gif

Affected versions

• Firefox 68.0a1 (BuildId:20190507214514)

Unaffected versions

• Firefox 67.0b18 (BuildId:20190506235559)
• Firefox 66.0.5 (BuildId:20190507012018)
• Firefox 60.6.1esr (BuildId:20190322020346)

Affected platforms

• Windows 10 64bit
• Ubuntu 16.04 32bit
• macOS 10.12.6

Steps to reproduce

1. Launch Firefox.
2. Click the Hamburger menu.
3. Click the Logins and Passwords button.
4. Click the tree column picker button.
5. Close the tree column picker menu.
6. Click the tree column picker button again.

Expected result

• The menu is successfully displayed.

Actual result

• The menu is wrongly displayed after being opened the second time.

Regression range

• First bad revision: 37d758a90ed9fc26c1d09993ddf73823295ea5d0
• Last good revision: ff20472890a1e3fa12e9b24bd9ef0520faea54da
• Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ff20472890a1e3fa12e9b24bd9ef0520faea54da&tochange=37d758a90ed9fc26c1d09993ddf73823295ea5d0
• Potential regressor: Bug 1500626

Additional Information

• I have attached a screencast for this issue.
• Please note that this seems to be reproducible with the tree column picker from the Certificate Manager dialog box (People tab) as well. It doesn’t seem reproducible with the tree column picker from the "Your Certificates", "Servers" and "Authorities" tabs.

Comment 1

[Emil Ghitta, QA [:emilghitta]]

Hi Brian,

It seems that mozregression pointed out Bug 1500626 for causing this regression.

Can you please take a look?

Thanks!

Comment 2

[Brian Grinstead [:bgrins]]

Looks like the children of <menuitem> in the tree col picker are getting [hidden] set on them. Taking a look.

Comment 3

[Emil Ghitta, QA [:emilghitta]]

Just a small update. This seems to be reproducible with the tree column picker from the "People" tab (Certificate Manager dialog box) as well.

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: Bug 1549931 - Only hide direct children of treecolpicker menupopups

Since the menuitem DOM is not anonymous anymore, without scoping the selector
we end up hiding contents of menuitems as well.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/633722f0bc3d
Only hide direct children of treecolpicker menupopups r=surkov

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/633722f0bc3d

Comment 7

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 68.0a1 (BuildId:20190515092556) on Windows 10 64bit, macOS 10.12.6 and Ubuntu 16.04 64bit.