1549965 - Consider enabling the GPU process for Linux

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Darkspirit]

https://searchfox.org/mozilla-central/rev/99a2a5a955960b0e58ceade1db1f7652d9db4ba1/modules/libpref/init/all.js#4984

As of bug 1543217 WebRender is enabled for Intel/Linux. Currently, any WebRender crash kills the whole browser.
It would also leave a usable browser in case of driver problems. In contrast, MacOS is not that diverse.
Any problem we ran into over time was reported and fixed (bug 1401634, bug 1406230, bug 1415020, bug 1430694, bug 1534557).

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=16960f27b1611f632e93dcea4ea60fed714c8aea

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1549965 - Enable GPU process by default on Linux if hardware compositing is used.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb107011caf5
Enable GPU process by default on Linux if hardware compositing is used. r=jrmuizel

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/96d95abd7de9
Backed out changeset cb107011caf5 for causing assertion failures on gfxFeature.cpp . CLOSED TREE

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for causing assertion failures on gfxFeature.cpp

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/96d95abd7de93d789ef5541a747a68995e24b514
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249228712&repo=mozilla-inbound&lineNumber=2517

Comment 6

[Andrew Osmond [:aosmond] (he/him)]

These assertions in gfxConfig::Disable variants are really getting me...

try with fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a1c6c21f8c53fc37654480d8a5842c574fd8d35

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/284dca344fcc
Enable GPU process by default on Linux if hardware compositing is used. r=jrmuizel

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/284dca344fcc

Comment 9

[Darkspirit]

Thanks :)

Comment 10

[Darkspirit]

Just in case. There is an old P5 bug: Don't click the "Terminate GPU process" button, otherwise everything is closed.

Comment 11

[Florin Strugariu [:Bebe]]

== Change summary for alert #21238 (as of Sun, 02 Jun 2019 02:31:45 GMT) ==

Improvements:

16% Resident Memory linux64-shippable-qr opt 972,112,105.41 -> 817,538,453.69

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=21238

Comment 12

[Darkspirit]

Improvements:
16% Resident Memory linux64-shippable-qr opt 972,112,105.41 -> 817,538,453.69

Why is there such a huge difference at all?
https://treeherder.mozilla.org/perf.html#/graphs?timerange=5184000&series=mozilla-inbound,1960833,1,4&series=mozilla-inbound,1960983,1,4&series=mozilla-inbound,1960783,1,4&series=mozilla-inbound,1960883,1,4&series=mozilla-inbound,2033014,1,4