Do not include a remove action for an abuse report on an add-on that doesn't have PERM_CAN_UNINSTALL

RESOLVED FIXED in Firefox 68

Status

()

defect
P1
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: rpl, Assigned: rpl)

Tracking

68 Branch
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 months ago

I'm not yet 100% convinced that we shouldn't hide the report action for add-ons that are system add-ons (or built-in add-ons/themes), but during Bug 1543377's review rounds we discussed about it with mstriemer and we agreed to show the report action for any extension or theme visible in about:addons, in other words "currently we don't assume that the user shouldn't be able to submit report on an add-on bundled in a build or developed by Mozilla itself" (at least until we re-evaluate this and decide that there are specific reasons to do otherwise).

In the meantime, at least, we shouldn't offer a remove action for a report submitted for an add-on that doesn't have a PERM_CAN_UNINSTALL permission flag.

Assignee

Updated

2 months ago
Assignee: nobody → lgreco
Blocks: 1543377
Status: NEW → ASSIGNED
Priority: -- → P1

Comment 2

2 months ago
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/c24c083425d0
No remove action on report submitted for add-ons without PERM_CAN_UNINSTALL. r=flod,mstriemer

Comment 3

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.