1550003 - "Compare" link on graphs page looses framework id

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I pushed a try build for a new kind of benchmark tests for Raptor, and want to check the various results of the ytp jobs. When clicking the link to the perfherder results I end-up on that graphs page:

https://treeherder.mozilla.org/perf.html#/graphs?series=try,2009297,1,10&selected=try,2009297,470806,804226121

When clicking compare in the popup (dark gray background) the following page gets opened:

https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&newProject=try&originalRevision=9c50a8779f3f2520a0c14a318f557b29b7445d91&newRevision=8b80929cca79b03383726fe97a22624a1061ed60&originalSignature=2009297&newSignature=2009297&framework=1

Sadly no results are shown, because the framework id is lost. Raptor has an id of 10 while here Talos is selected which has 1.

It would be pretty helpful if the graphs page directly opens the target page for the appropriate framework.

Comment 1

[Sarah Clements [:sclements]]

Fixed in this commit: https://github.com/mozilla/treeherder/commit/47b53c157ad5a1c496aa765c4a9c6cc7d3fdb9ae