155002 - mozilla should remain active application when dismissing an alert that was raised when mozilla wasn't active

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[:deanis74]

Wow, that's a long summary!

1. Enter in a non-existent url, eg. www.blahblahblah.com
2. Quickly Alt+Tab to another application
3. Wait for the taskbar icon to flash
4. Click the taskbar icon and dismiss the alert

Expected Results: Mozilla is now the active application

Actual Results: Focus switches back to the application changed to in step 2

2002062908 on Win2K

Comment 1

[:deanis74]

Step 2 doesn't have to be another application, it can be another Mozilla window.

Comment 2

[:deanis74]

Adding dmose to cc: list, since this is a focus bug.

Comment 3

[Ere Maijala (slow)]

I did a bit debugging. Making nsXULWindow::ActivateParent() return immediately
seems to make this work almost perfectly. The focus doesn't jump around, but the
parent doesn't get it either. This is the same behavior that Delphi apps seem to
have. In conclusion, it seems to me that ActivateParent() doesn't activate what
it should. 

Comment 4

[Ere Maijala (slow)]

Then again, I might be wrong. It seems to be intermittent.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Removing myself.  I know next to nothing about the focus code.  You'd probably
be better off ccing [e-mail] and [e-mail].

Comment 6

[:deanis74]

Whoops, I meant to cc: danm about window focus, not dmose.

Comment 7

[Ere Maijala (slow)]

I did some digging on this again. It seems that Windows will focus the last
active window when the modal window is hidden. I think we should always do
something alike ActivateParent() after hiding the modal window. Currently
ActivateParent() is only used in certain situations because (according to a
comment) it causes problems otherwise. Could it be because it is called before
the parent window is enabled? I'll probably try calling it after ExitModalLoop().

Comment 8

[[e-mail]]

Ere, I always thought that Windows would activate the uppermost enabled window
when you hide a top-level window. Is the modal parent not being enabled soon enough?

Comment 9

[Samir Gehani]

-> danm for a look.  We should try to fix this for Buffy since it is in line
with the theme of polish.

Comment 10

[Ere Maijala (slow)]

I've checked in a fix for bug 189085. It fixed this issue too (at least for me).
Marking fixed.

Comment 11

[[e-mail]]

Great work Ere!