1550059 - Very frequent Android non-e10s dom/serviceworkers/test/test_self_update_worker.html | application crashed [@ RefPtr<mozilla::dom::(anonymous namespace)::AllowWindowInteractionHandler>::operator->() const + 0x2c] when Gecko 68 merges to Beta on 2019-05-07

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect, P1)

Description

[Dorel Luca [:dluca]]

Central as beta simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception&revision=3597979ddc1bd3db4fae1575eecc83090459f6b5&selectedJob=245342624

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=245342624&repo=try&lineNumber=1461

Failure:
dom/serviceworkers/test/test_self_update_worker.html | application crashed [@ RefPtr<mozilla::dom::(anonymous namespace)::AllowWindowInteractionHandler>::operator->() const + 0x2c]

Comment 1

[Dorel Luca [:dluca]]

Can you please take a look at this bug?

Comment 2

[Andrew Overholt [:overholt]]

I don't know how this is failing in the "central as beta" simulation but that seems bad so please take a look, Perry :)

Comment 3

[Perry Jiang [:perry] [no longer employee, use ni?]]

Based on the treeherder log:

• The crash occurs after a test completes (likely during shutdown)
• The stack trace shows the crash occurs during a timer callback
• The crash (i.e. stack frame 0) is due to a pointer dereference, where the pointer is nulled during shutdown

So, it seems like a race condition that can be prevented by either clearing the timer at the right time (or performing a null-check on the pointer).

Comment 4

[Perry Jiang [:perry] [no longer employee, use ni?]]

Attachment: Bug 1550059 - Clear ServiceWorker(Registration)Infos on shutdown. r?asuth

Comment 5

[Alexandru Michis [:malexandru]]

Central as early beta sim: https://treeherder.mozilla.org/#/jobs?repo=try&revision=515741fed29ee61d5181d8b87fbf3274333b017f&searchStr=%2823%29

This fix seems to solve the current issue.

Comment 6

[Andreea Pavel [:apavel]]

Perry can this be landed?

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Andreea Pavel [:apavel] from comment #6)

Perry can this be landed?

It needs a review.

Comment 9

[Perry Jiang [:perry] [no longer employee, use ni?]]

Patch landing enqueued.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/432bd29bd80c
Clear ServiceWorker(Registration)Infos on shutdown. r=asuth

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/432bd29bd80c

Comment 12

[Julien Cristau [:jcristau]]

Mind requesting uplift to beta if appropriate?

Comment 13

[Perry Jiang [:perry] [no longer employee, use ni?]]

Comment on attachment 9064157 [details]
Bug 1550059 - Clear ServiceWorker(Registration)Infos on shutdown. r?asuth

Beta/Release Uplift Approval Request

• User impact if declined: Intermittent crash
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch isn't doing anything except cleaning things up that aren't expected to be used anymore after a certain point in the shutdown process.
• String changes made/needed:

Comment 14

[Intermittent Failures Robot]

6 failures in 4337 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 6

Platform breakdown:

• android-em-4-3-armv7-api16: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1550059&startday=2019-05-27&endday=2019-06-02&tree=all

Comment 15

[Julien Cristau [:jcristau]]

Comment on attachment 9064157 [details]
Bug 1550059 - Clear ServiceWorker(Registration)Infos on shutdown. r?asuth

serviceworker cleanup on shutdown, approved for 68.0b8

Comment 16

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/d9d324c0221e

Comment 17

[Intermittent Failures Robot]

3 failures in 5197 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 3

Platform breakdown:

• android-em-4-3-armv7-api16: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1550059&startday=2019-06-03&endday=2019-06-09&tree=all