1550075 - Enable smart sizing of http disk cache on android within raptor (browser.cache.disk.smart_size)

Status: RESOLVED FIXED

(Testing :: Raptor, task, P1)

Description

[Andrew Creskey [:acreskey]]

Shipped android apps enable smart sizing of the http disk cache (browser.cache.disk.smart_size.enabled) - see preference here.

However in the performance profile this is disabled for all platforms:
https://searchfox.org/mozilla-central/rev/197210b8c139b64f642edaa3336d26b9c1761568/testing/profiles/perf/user.js#8

On android in particular the default of a small disk cache causes performance issues on a couple of sites. See Bug 1536171
(notably a 20% impact on pageload for raptor-tp6m-microsoft-support-geckoview opt)

Since android performance tests are not run on shared hardware (e.g. AWS), we cannot think of a reason to disable the smart sizing of the disk cache.

So the bug is to not set the browser.cache.disk.smart_size.enabled preference to false on android so that the test environment more closely matches the user experience.

Comment 1

[Andrew Creskey [:acreskey]]

Attachment: AddAndroidProfileToRaptor.diff

Rob, I took a stab at how we would do this.
If this is reasonable I'll put it up for review.

Comment 2

[Andrew Creskey [:acreskey]]

Can you have a look at the above please?
I'm not attached to this implementation but I think this is an important change (see Bug 1536171 for more details).

Comment 3

[Robert Wood [:rwood]]

(In reply to Andrew Creskey from comment #2)

Can you have a look at the above please?
I'm not attached to this implementation but I think this is an important change (see Bug 1536171 for more details).

Hi Andrew, sorry I missed when you originally added your patch a week ago. Yep this implementation LGTM - I like the idea of having a separate profile for raptor-android. Hopefully that will just work and override the setting in the performance profile!

Comment 4

[Andrew Creskey [:acreskey]]

Attachment: Bug 1550075 - Add android user profile to raptor, enable smart disk cache sizing r=rwood

A new user profile, raptor-android, was added. This profile is merged with existing profiles in RaptorAndroid.
browser.cache.disk.smart_size.enabled was enabled in test since it is enabled in shipped apps.
See https://searchfox.org/mozilla-central/rev/11cfa0462a6b5d8c5e2111b8cfddcf78098f0141/mobile/android/app/mobile.js#74

Comment 5

[Andrew Creskey [:acreskey]]

Rob, yes, the android raptor profile is merged last and overrides any previous settings.
So far I've only added one pref: restoring the browser.cache.disk.smart_size.enabled to our android default, enabled.

This is a big performance and noise improvement on raptor-tp6m-microsoft-support-geckoview :
https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&newProject=try&newRevision=a748fe3a82c513f4b6740bea98f615e61119c0e3&originalSignature=1930816&newSignature=1930816&framework=10&originalRevision=ca4e9f859f7666f10e9fbc74c09619225eda8126

Comment 6

[Andrew Creskey [:acreskey]]

Attachment: raptor-tp6m-microsoft-support-geckoview.png

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5862c607fcc2
Add android user profile to raptor, enable smart disk cache sizing r=rwood

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0e9df8a81b0
Backed out changeset 5862c607fcc2 for eslint failure on raptor-android/user.js.

Comment 9

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed&revision=5862c607fcc245c3686bd67f7d2beae39b7f1694&selectedJob=247638508

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=247638508&repo=autoland&lineNumber=267
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=247638516&repo=autoland&lineNumber=215

Backout link: https://hg.mozilla.org/integration/autoland/rev/f0e9df8a81b0ec75a63b03363154df4dcc6cf157

[task 2019-05-21T22:27:36.559Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-05-21T22:35:18.716Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/profiles/raptor-android/user.js:3:1 | 'user_pref' is not defined. (no-undef)
[task 2019-05-21T22:35:18.716Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/profiles/raptor-android/user.js:3:58 | Newline required at end of file but not found. (eol-last)
[taskcluster 2019-05-21 22:35:19.081Z] === Task Finished ===

Comment 10

[Andrew Creskey [:acreskey]]

Ah, I forgot to eslint -- thank you for backing that out :CosminS -- that's now been fixed.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09df445cbdd9
Add android user profile to raptor, enable smart disk cache sizing r=rwood

Comment 12

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 09df445cbdd9 (bug 1550075) for f8 linting failure at raptor.py:857:10.

Backout: https://hg.mozilla.org/integration/autoland/rev/6f891c10e2da60e2d5d33e1baa9d9fc7d2444350

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=09df445cbdd9e26d88c00d4a4bc5bd7c3c2137bc&selectedJob=247757166

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=247757166&repo=autoland&lineNumber=262

Comment 13

[Andrew Creskey [:acreskey]]

Thanks [:cbrindusan] -- the patch has been updated and is now linting clean.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31b1c62e8179
Add android user profile to raptor, enable smart disk cache sizing r=rwood

Comment 15

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/31b1c62e8179