Edit stored login details
Categories
(Firefox :: about:logins, enhancement, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox68 | --- | verified |
People
(Reporter: jaws, Assigned: jaws)
References
(Depends on 1 open bug)
Details
(Whiteboard: [passwords:management] [skyline] )
Attachments
(3 files)
The LoginItem should be editable and the user should be able to save edits to the login details. The lastUpdatedTime should be updated accordingly.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
Updated•5 years ago
|
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b1519a245b74 Remove code duplication for forwarding Fluent strings in shadow DOM on the LoginItem. r=MattN,Pike https://hg.mozilla.org/integration/autoland/rev/9f3df4002962 Put LoginItem styles in an external stylesheet. r=MattN https://hg.mozilla.org/integration/autoland/rev/741b2f74227b Add Save Changes and Cancel button for LoginItem. r=MattN,Pike
Comment 5•5 years ago
|
||
Backed out 8 changesets (Bug 1549803, Bug 1550095) for browser-chrome failuire at browser/components/aboutlogins/tests/browser/browser_updateLogin.js
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=245853858&repo=autoland&lineNumber=3721
[task 2019-05-10T22:15:52.235Z] 22:15:52 INFO - GECKO(2989) | console.warn: LoginHelper: "Couldn't parse origin for" "about:logins" ({})
[task 2019-05-10T22:15:52.236Z] 22:15:52 INFO - GECKO(2989) | console.warn: LoginHelper: "Couldn't parse origin for" "about:logins" ({})
[task 2019-05-10T22:15:52.257Z] 22:15:52 INFO - GECKO(2989) | JavaScript error: , line 0: uncaught exception: [fluent][resolver] errors in en-US/login-item: ReferenceError: Unknown variable: timeCreated, ReferenceError: Unknown variable: timeChanged, ReferenceError: Unknown variable: timeUsed.
[task 2019-05-10T22:15:57.426Z] 22:15:57 INFO - TEST-INFO | started process screentopng
[task 2019-05-10T22:15:57.958Z] 22:15:57 INFO - TEST-INFO | screentopng: exit 0
[task 2019-05-10T22:15:57.958Z] 22:15:57 INFO - Buffered messages logged at 22:15:51
[task 2019-05-10T22:15:57.960Z] 22:15:57 INFO - Entering test bound setup
[task 2019-05-10T22:15:57.961Z] 22:15:57 INFO - Buffered messages logged at 22:15:52
[task 2019-05-10T22:15:57.962Z] 22:15:57 INFO - Console message: [JavaScript Error: "uncaught exception: [fluent][resolver] errors in en-US/login-item: ReferenceError: Unknown variable: timeCreated, ReferenceError: Unknown variable: timeChanged, ReferenceError: Unknown variable: timeUsed."]
[task 2019-05-10T22:15:57.964Z] 22:15:57 INFO - Leaving test bound setup
[task 2019-05-10T22:15:57.965Z] 22:15:57 INFO - Entering test bound test_show_logins
[task 2019-05-10T22:15:57.966Z] 22:15:57 INFO - Buffered messages finished
[task 2019-05-10T22:15:57.969Z] 22:15:57 INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/browser/browser_updateLogin.js | Uncaught exception - Waiting for login to be displayed - timed out after 50 tries.
[task 2019-05-10T22:15:57.970Z] 22:15:57 INFO - Leaving test bound test_show_logins
[task 2019-05-10T22:15:57.971Z] 22:15:57 INFO - Entering test bound test_login_item
[task 2019-05-10T22:15:57.971Z] 22:15:57 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-05-10T22:15:57.974Z] 22:15:57 INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/browser/browser_updateLogin.js | Uncaught exception - TypeError: loginListItem is null
[task 2019-05-10T22:15:57.975Z] 22:15:57 INFO - Leaving test bound test_login_item
[task 2019-05-10T22:15:57.975Z] 22:15:57 INFO - GECKO(2989) | MEMORY STAT | vsize 20974891MB | residentFast 1007MB
[task 2019-05-10T22:15:57.982Z] 22:15:57 INFO - TEST-OK | browser/components/aboutlogins/tests/browser/browser_updateLogin.js | took 5706ms
[task 2019-05-10T22:15:57.991Z] 22:15:57 INFO - checking window state
[task 2019-05-10T22:15:59.953Z] 22:15:59 INFO - GECKO(2989) | Completed ShutdownLeaks collections in process 3117
[task 2019-05-10T22:16:00.014Z] 22:16:00 INFO - GECKO(2989) | Completed ShutdownLeaks collections in process 3173
[task 2019-05-10T22:16:00.042Z] 22:16:00 INFO - GECKO(2989) | Completed ShutdownLeaks collections in process 3146
[task 2019-05-10T22:16:00.100Z] 22:16:00 INFO - GECKO(2989) | Completed ShutdownLeaks collections in process 3041
[task 2019-05-10T22:16:00.197Z] 22:16:00 INFO - GECKO(2989) | Completed ShutdownLeaks collections in process 3062
[task 2019-05-10T22:16:00.974Z] 22:16:00 INFO - GECKO(2989) | Completed ShutdownLeaks collections in process 2989
Assignee | ||
Updated•5 years ago
|
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4a3dacc5d3b2 Remove code duplication for forwarding Fluent strings in shadow DOM on the LoginItem. r=MattN,Pike https://hg.mozilla.org/integration/autoland/rev/93a0674140fc Put LoginItem styles in an external stylesheet. r=MattN https://hg.mozilla.org/integration/autoland/rev/c5d450a431c8 Add Save Changes and Cancel button for LoginItem. r=MattN,Pike
Comment 7•5 years ago
|
||
Backed out 8 changesets (bug 1549803, bug 1550095) for Browser-chrome failures in browser/components/aboutlogins/tests/browser/browser_updateLogin.js
Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=245908190&repo=autoland&lineNumber=3742
Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=af805180a1e6329754d626a62d17bdca87ffc2b0
Backout:
https://hg.mozilla.org/integration/autoland/rev/1be22e2d35d1e2a40451b2d555ced98a49d533af
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e44ae9304b95 Remove code duplication for forwarding Fluent strings in shadow DOM on the LoginItem. r=MattN,Pike https://hg.mozilla.org/integration/autoland/rev/e8f9b82c0a28 Put LoginItem styles in an external stylesheet. r=MattN https://hg.mozilla.org/integration/autoland/rev/e4f48fcdd4a3 Add Save Changes and Cancel button for LoginItem. r=MattN,Pike
Comment 9•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e44ae9304b95
https://hg.mozilla.org/mozilla-central/rev/e8f9b82c0a28
https://hg.mozilla.org/mozilla-central/rev/e4f48fcdd4a3
Assignee | ||
Updated•5 years ago
|
Comment 10•5 years ago
|
||
Hi Jared,
I would like to verify this one but I didn't really find the "Save Changes" and "Cancel" button for LoginItem. Are these back-end changes without visible UI changes implemented? Please let me know if so or otherwise some additional guidance would be appreciated. Thanks!
Assignee | ||
Comment 11•5 years ago
|
||
Hi Timea, you will have to click the Edit button before the Save Changes and Cancel button become visible.
Comment 12•5 years ago
|
||
Wasn't aware that this is all on about:logins page and thought it is something new at about:preferences#privacy.
Anyway, this is verified - fixed on latest Nightly 68.0a1 (2019-05-16) (64-bit) on Windows 10, Mac OS 10.13 and Ubuntu 18.04.
The "Save" and "Cancel" button are displayed and functional while editing saved login credentials.
Updated•5 years ago
|
Description
•