Create CustomElement for toggling text on a input field
Categories
(Firefox :: about:logins, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | verified |
People
(Reporter: jaws, Assigned: jaws)
References
Details
(Whiteboard: [passwords:management] [skyline] )
Attachments
(5 files)
This custom element will show the masked password as a fixed number of characters regardless of password length, and upon revealing will replace the masked characters with a input[type=password] textbox. Masking the characters will revert the behavior. Password changes will still be committed if the password is revealed, changed, hidden, then saved.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
This element should also be used for the username field, where we will display the text outside of an input if it is not in 'edit' mode.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
|
Assignee | |
Comment 6•5 years ago
|
||
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c9f9e36d2af7 Create basic custom element for a modal input. r=MattN https://hg.mozilla.org/integration/autoland/rev/abde24c1d7ee Use modal-input custom element for login-item. r=MattN https://hg.mozilla.org/integration/autoland/rev/ed88d536588f Move Delete button to be inline with the LoginItem title. r=MattN https://hg.mozilla.org/integration/autoland/rev/48567f3c473a Add Edit button that toggles between editing/not-editing a LoginItem. r=MattN,Pike https://hg.mozilla.org/integration/autoland/rev/044fba1f3da7 Add reveal button for modal-input[type=password]. r=MattN,Pike
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c9f9e36d2af7
https://hg.mozilla.org/mozilla-central/rev/abde24c1d7ee
https://hg.mozilla.org/mozilla-central/rev/ed88d536588f
https://hg.mozilla.org/mozilla-central/rev/48567f3c473a
https://hg.mozilla.org/mozilla-central/rev/044fba1f3da7
|
||
Comment 9•5 years ago
|
||
Verified - fixed on latest Nightly 68.0a1 (2019-05-17) (64-bit) on Windows 10 x64, Mac OS 10.14 and Ubuntu 18.04.
- The password is masked with a fixed number of characters regardless of it's length
- Upon revealing the password in edit mode, the field will switch to an input textbox and hiding the paassword once again will revert this
- Password changes will be committed once the "Save Changes" button is hit after revealing, changing and hiding the password
- The field for the username will also transition to an input type filed only when the credentials are in edit mode
|
||
Updated•5 years ago
|
Description
•