RTCPeerConnection fires "complete" but never "gathering" icegatheringstatechange on answerer side

RESOLVED FIXED in Firefox 69

Status

()

defect
P2
normal
RESOLVED FIXED
3 months ago
28 days ago

People

(Reporter: jib, Assigned: bwc)

Tracking

unspecified
mozilla69
Points:
---

Firefox Tracking Flags

(firefox69 fixed)

Details

Attachments

(7 attachments, 1 obsolete attachment)

Posted image Screenshot

STRs:

  1. Open https://jsfiddle.net/jib1/y6dxtks9/
  2. Check the top ☐ Camera
  3. Allow camera permission if necessary

Expected results:
.-iframe---
| ☑ Camera ☐ Noise ☑ Log [Restart]
| gathering
| onicecandidate: 268e41f8
| onicecandidate: 268e41f8
| onicecandidate: 268e41f8
| onicecandidate: 268e41f8
| onicecandidate: 268e41f8
| complete
| addIceCandidate: c724b6be
| addIceCandidate: c724b6be
| addIceCandidate: c724b6be
|
'---
☐ Camera ☐ Noise ☑ Log [Restart]
gathering
onicecandidate: c724b6be
onicecandidate: c724b6be
onicecandidate: c724b6be
complete
addIceCandidate: 268e41f8
addIceCandidate: 268e41f8
addIceCandidate: 268e41f8
addIceCandidate: 268e41f8
addIceCandidate: 268e41f8

Actual results:
.-iframe---
| ☑ Camera ☐ Noise ☑ Log [Restart]
| gathering
| onicecandidate: 268e41f8
| onicecandidate: 268e41f8
| onicecandidate: 268e41f8
| onicecandidate: 268e41f8
| onicecandidate: 268e41f8
| complete
| addIceCandidate: c724b6be
| addIceCandidate: c724b6be
| addIceCandidate: c724b6be
|
'---
☐ Camera ☐ Noise ☑ Log [Restart]
complete
onicecandidate: c724b6be
onicecandidate: c724b6be
onicecandidate: c724b6be
addIceCandidate: 268e41f8
addIceCandidate: 268e41f8
addIceCandidate: 268e41f8
addIceCandidate: 268e41f8
addIceCandidate: 268e41f8

Attachment #9063631 - Attachment is obsolete: true

FYI the order of events on the answerer side seem inconsistent. Sometimes I see this order:

addIceCandidate: 3e59ea5b
addIceCandidate: 3e59ea5b
addIceCandidate: 3e59ea5b
addIceCandidate: 3e59ea5b
addIceCandidate: 3e59ea5b
complete
onicecandidate: 8a229bd5
onicecandidate: 8a229bd5
onicecandidate: 8a229bd5

The "gathering" event is always missing however.

Attachment #9063631 - Attachment is obsolete: false
Assignee: nobody → docfaraday

Looking into this.

Ok, it just looks like we're skipping the transition to "gathering" sometimes.

https://jsfiddle.net/L3bat8pc/1/

Whew, there's a lot of cruft to clean up here.

Attachment #9063851 - Attachment is obsolete: true

Try looks good.

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:bwc, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(docfaraday)
Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1ff47be32265
Part 0: Test-case for bug. r=jib
https://hg.mozilla.org/integration/autoland/rev/22a2b3e65223
Part 1: Remove some duplicate webidl enums. r=mjf,smaug
https://hg.mozilla.org/integration/autoland/rev/4ce46b3be46e
Part 2: Remove a stack-unwind, and simplify signal handling considerably. r=mjf
https://hg.mozilla.org/integration/autoland/rev/01c9aca20892
Part 3: There is no need to dispatch these calls to STS, because MediaTransportHandler does that for us. r=mjf
https://hg.mozilla.org/integration/autoland/rev/2653b8243f4f
Part 4: Simplify ICE gathering state change callback stuff. r=jib
https://hg.mozilla.org/integration/autoland/rev/8f9779bb2d41
Part 5: Remove one more bit of cruft. r=mjf
Flags: needinfo?(docfaraday)
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17451 for changes under testing/web-platform/tests
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.