RTCPeerConnection fires "complete" but never "gathering" icegatheringstatechange on answerer side
Categories
(Core :: WebRTC, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: jib, Assigned: bwc)
Details
Attachments
(7 files, 1 obsolete file)
1.21 MB,
image/png
|
Details | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
STRs:
- Open https://jsfiddle.net/jib1/y6dxtks9/
- Check the top ☐ Camera
- Allow camera permission if necessary
Expected results:
.-iframe---
| ☑ Camera ☐ Noise ☑ Log [Restart]
| gathering
| onicecandidate: 268e41f8
| onicecandidate: 268e41f8
| onicecandidate: 268e41f8
| onicecandidate: 268e41f8
| onicecandidate: 268e41f8
| complete
| addIceCandidate: c724b6be
| addIceCandidate: c724b6be
| addIceCandidate: c724b6be
|
'---
☐ Camera ☐ Noise ☑ Log [Restart]
gathering
onicecandidate: c724b6be
onicecandidate: c724b6be
onicecandidate: c724b6be
complete
addIceCandidate: 268e41f8
addIceCandidate: 268e41f8
addIceCandidate: 268e41f8
addIceCandidate: 268e41f8
addIceCandidate: 268e41f8
Actual results:
.-iframe---
| ☑ Camera ☐ Noise ☑ Log [Restart]
| gathering
| onicecandidate: 268e41f8
| onicecandidate: 268e41f8
| onicecandidate: 268e41f8
| onicecandidate: 268e41f8
| onicecandidate: 268e41f8
| complete
| addIceCandidate: c724b6be
| addIceCandidate: c724b6be
| addIceCandidate: c724b6be
|
'---
☐ Camera ☐ Noise ☑ Log [Restart]
complete
onicecandidate: c724b6be
onicecandidate: c724b6be
onicecandidate: c724b6be
addIceCandidate: 268e41f8
addIceCandidate: 268e41f8
addIceCandidate: 268e41f8
addIceCandidate: 268e41f8
addIceCandidate: 268e41f8
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 1•5 years ago
|
||
FYI the order of events on the answerer side seem inconsistent. Sometimes I see this order:
addIceCandidate: 3e59ea5b
addIceCandidate: 3e59ea5b
addIceCandidate: 3e59ea5b
addIceCandidate: 3e59ea5b
addIceCandidate: 3e59ea5b
complete
onicecandidate: 8a229bd5
onicecandidate: 8a229bd5
onicecandidate: 8a229bd5
The "gathering" event is always missing however.
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
•
|
||
Looking into this.
Assignee | ||
Comment 3•5 years ago
|
||
Ok, it just looks like we're skipping the transition to "gathering" sometimes.
Assignee | ||
Comment 4•5 years ago
|
||
This seems to be due to the extra stack unwind we're doing here:
Assignee | ||
Comment 5•5 years ago
|
||
Whew, there's a lot of cruft to clean up here.
Assignee | ||
Comment 6•5 years ago
|
||
Assignee | ||
Comment 7•5 years ago
|
||
Assignee | ||
Comment 8•5 years ago
|
||
Depends on D30990
Assignee | ||
Comment 9•5 years ago
|
||
Depends on D30991
Assignee | ||
Comment 10•5 years ago
|
||
Depends on D30992
Assignee | ||
Comment 11•5 years ago
|
||
Depends on D30993
Assignee | ||
Comment 12•5 years ago
|
||
Depends on D30994
Assignee | ||
Comment 13•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f39f27c10868b29a5914867c62e4c7812cc8b57b
Updated•5 years ago
|
Assignee | ||
Comment 14•5 years ago
|
||
Try looks good.
Comment 15•5 years ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:bwc, could you have a look please?
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 16•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b014708c4a49bd80c490a4772c9ae4579ea26aee
Comment 17•5 years ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1ff47be32265 Part 0: Test-case for bug. r=jib https://hg.mozilla.org/integration/autoland/rev/22a2b3e65223 Part 1: Remove some duplicate webidl enums. r=mjf,smaug https://hg.mozilla.org/integration/autoland/rev/4ce46b3be46e Part 2: Remove a stack-unwind, and simplify signal handling considerably. r=mjf https://hg.mozilla.org/integration/autoland/rev/01c9aca20892 Part 3: There is no need to dispatch these calls to STS, because MediaTransportHandler does that for us. r=mjf https://hg.mozilla.org/integration/autoland/rev/2653b8243f4f Part 4: Simplify ICE gathering state change callback stuff. r=jib https://hg.mozilla.org/integration/autoland/rev/8f9779bb2d41 Part 5: Remove one more bit of cruft. r=mjf
Assignee | ||
Updated•5 years ago
|
Comment 18•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1ff47be32265
https://hg.mozilla.org/mozilla-central/rev/22a2b3e65223
https://hg.mozilla.org/mozilla-central/rev/4ce46b3be46e
https://hg.mozilla.org/mozilla-central/rev/01c9aca20892
https://hg.mozilla.org/mozilla-central/rev/2653b8243f4f
https://hg.mozilla.org/mozilla-central/rev/8f9779bb2d41
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17451 for changes under testing/web-platform/tests
Upstream PR merged
Description
•