1550194 - Rerun all selected jobs from the pinboard menu

Status: RESOLVED WORKSFORME

(Tree Management :: Treeherder, enhancement)

Description

[Andreea Pavel [:apavel]]

There was an infra issue tonight and I had to rerun a few builds.
In this case there were not many builds, however a button to rerun all, where the retrigger all in the pinboard would be most welcomed.

Push was https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=efc907d677c24b15d2f652e41efa6bca3239fbcc

Comment 1

[Andreea Pavel [:apavel]]

Cameron is there something you could do here? or assign to someone?

We had issues again and reruning manually takes up a lot of time especially at this number:

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&resultStatus=busted%2Cexception&selectedJob=250723576

Comment 2

[Cameron Dawson [:camd]]

Hi Andrea-- Yes, this sounds totally reasonable. I'll bring it up with Karl to see if we can find someone to work on this.

Wes-- I don't suppose this is something you'd be up for working on? I don't know your workload, but figured I'd ping you. :)

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Screenshot_2019-06-11 [1] mozilla-central.png

There's already a "retrigger all" button in the pinboard. I'm not sure how well it works if jobs in the pinboard span multiple pushes, but it should work just fine if all of the pinned jobs are from a single push.

Comment 4

[Andreea Pavel [:apavel]]

Hi guys, not retrigger, but rerun, for builds specifically as we needed for https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&resultStatus=busted%2Crunnable&revision=522a2bc06f9e5d0767bb3f2e127cc21eeaeb8a78&selectedJob=250720301 . in this case, we selected every failure separately and reran it from Custom actions.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

My understanding is that the retrigger action is now a bit smarter (bug 1450012) about what happens when it runs against builds. It should end up transforming into a re-run automatically:

I just pinned two of the failing 'ach' jobs on the linked push and used the "Retrigger all" button to request a retrigger. The retrigger task then refused to trigger any new jobs, but it does say No need to to rerun the requested tasks because they already completed. I assume that's because the older re-runs already finished successfully?

Tom can correct me if my understanding is wrong.

Comment 6

[Tom Prince [:tomprince]]

That is correct, the retrigger-multiple (which is what is used by treeherder) will automatically rerun stuff that should be rerun. There are a couple of things it currently fails to do anything with (partials), and there may be bugs about what it chooses to rerun vs retrigger, but those should be filed as bugs.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I think we can close this bug as worksforme, then.

@sheriffs: If Treeherder's retriggering isn't automatically converting retriggers into reruns where it's supposed to, please file a taskcluster bug about them so they can get identified and fixed.

Comment 8

[Karl Thiessen [:kthiessen, he/him]]

Thanks, Wes.

Comment 9

[Andreea Pavel [:apavel]]

Thank you for clarifying that. We'll file the bug when and if necessary.