[wpt-sync] Sync PR 16268 - Refactor lint rules
Categories
(Testing :: web-platform-tests, defect, P4)
Tracking
(firefox69 fixed)
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream error])
Sync web-platform-tests PR 16268 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/16268
Details from upstream follow.
Mike Pennisi <mike@mikepennisi.com> wrote:
Refactor lint rules
As described in gh-15824, we're revamping WPT's documentation in a fork of the project. We'd like to automatically generate rules for the project's linter, and that requires some change to the source code. In the initial proposal for that improvement, @jgraham wrote:
This approach looks good. Please endeavour to land the lint changes upstream rather than in a docs branch, even if the motivating documentation isn't ready yet, otherwise there's a severe chance of conflicts which in this case would likely lead to regressing whole lint rules.
This is the requested change.
Because not all rules are backed with unit tests, the first commit in this patch improves coverage. Two rules remain uncovered:
IGNORED PATH- because this rule integrates with git and the filesystem, testing it effectively is non-trivialMALFORMED-VARIANT- the application code has an assertion guarding against this
case which resists attempts to test. Should we change the assertion to araiseand remove the linting rule?
|
Assignee | |
Updated•5 years ago
|
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/3bb3f2ed272d [wpt PR 16268] - Refactor lint rules, a=testonly
|
||
Comment 2•5 years ago
|
||
| bugherder | ||
Description
•