[wpt-sync] Sync PR 16373 - Always leave an event in the AudioParam timeline
Categories
(Core :: Web Audio, defect, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 16373 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/16373
Details from upstream follow.
Raymond Toy <rtoy@chromium.org> wrote:
Always leave an event in the AudioParam timeline
Previously, when the last AudioParam event has been processed and is
now in the past, the event would be removed from the timeline. This
was an optimization so that we can skip sample-accurate processing of
the timeline and just returned fixed values. However, if a new event
is added after all events have been deleted, the starting point of the
event could be incorrect. For example a setValueAtTime event in the
past followed by a linearRampToValueAtTime.Therefore, always leave the very last event in the timeline to
establish the starting event if needed by future events.Bug: 951863
Change-Id: Iae0b550a4b497b953a10e85e603ecebb59508a99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565375
Commit-Queue: Raymond Toy \<rtoy@chromium.org>
Reviewed-by: Hongchan Choi \<hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652955}
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Comment 3•6 years ago
|
||
bugherder |
Description
•