Closed Bug 1550255 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 16476 - [LayoutNG] Fix propagation of forcing clearance.

Categories

(Testing :: web-platform-tests, defect, P4)

defect

Tracking

(firefox69 fixed)

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16476 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16476
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[LayoutNG] Fix propagation of forcing clearance.

Previously if a child cleared an adjoining float, a grandchild may be
the element to resolve that subtree's BFC-block-offset.

When this occurred that grandchild didn't know that it should be
forced to clear a certain float.

This patch propagates the "ShouldForceClearance" bit down to arbitrary
grandchildren.

Bug: 944083
Change-Id: Iedb023c01ff4c3aa3dd83b6e7b0cfc08afb13aad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582271
Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick \<ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653821}

Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/62688ce71668
[wpt PR 16476] - [LayoutNG] Fix propagation of forcing clearance., a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.