Closed Bug 1550263 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 16564 - Test multi-threaded ConvolverNode

Categories

(Core :: Web Audio, defect, P4)

Product:
Core
Component:
Web Audio
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16564 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16564
Details from upstream follow.

Raymond Toy <rtoy@chromium.org> wrote:

Test multi-threaded ConvolverNode

Add test for ConvolverNode running on a real-tiem AudioContext. In
addition to being a general test, this also tests that the
multi-threaded convolver implementation in Chrome (and perhaps other
browsers) works correctly.

The length of the convolver imuplse response was selected to ensure
that extra threads are used in Chrome. This was verified by putting a
(temporary) print where the threads are created.

Bug: 956085
Test: realtime-conv.html
Change-Id: Ia273f2e3fdba0b0ac79a03507801dc1c7b3c5006
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586231
Commit-Queue: Raymond Toy \<rtoy@chromium.org>
Reviewed-by: Hongchan Choi \<hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654637}

Component: web-platform-tests → Web Audio
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/334f45edcc03
[wpt PR 16564] - Test multi-threaded ConvolverNode, a=testonly

https://hg.mozilla.org/mozilla-central/rev/334f45edcc03

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.