Closed Bug 1550293 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 16292 - [Animation Worklet] Copy the effects of a migrating animator over to new global scope

Categories

(Testing :: web-platform-tests, defect, P4)

Product:
Testing
Component:
web-platform-tests
Type:
defect

Tracking

(firefox69 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16292 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16292
Details from upstream follow.

Yi Gu <yigu@chromium.org> wrote:

[Animation Worklet] Copy the effects of a migrating animator over to new global scope

The effect.localTime is reset to null upon switching global scopes for
stateless animators. The following test [1] is flaky because it's possible
that we query the localTime when it's just been reset.

This patch preseves the local time of effects upon switching by copying
the effects from the old animator to the new one.

[1] virtual/threaded/external/wpt/animation-worklet/worklet-animation-duration.https.html

Change-Id: Ic4063d68c0d69ace4ec8866bb0a33ba78dff5a38
Bug: 951753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556639
Commit-Queue: Yi Gu \<yigu@chromium.org>
Reviewed-by: Majid Valipour \<majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651009}

PR 16292 applied with additional changes from upstream: 4688078c2cc6e81651b220f3c1944d956f63046b
Failed to get results from try push
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/413666b71649 [wpt PR 16292] - [Animation Worklet] Copy the effects of a migrating animator over to new global scope, a=testonly

https://hg.mozilla.org/mozilla-central/rev/413666b71649

Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.