1550304 - [wpt-sync] Sync PR 16604 - Revert "Reland "bluetooth: FakeBluetoothChooser impl.""

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 16604 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16604
Details from upstream follow.

Dominik Röttsches <[e-mail]> wrote:

Revert "Reland "bluetooth: FakeBluetoothChooser impl.""

This reverts commit cb85732cb3be7cf442e5c3afe6a3625f7edee10b.

Reason for revert: Suspected to cause bluetooth tests to timeout on Linux ASAN bot, compare https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20ASAN/25348 and issue 957867

Bug: 957867

Original change's description:

Reland "bluetooth: FakeBluetoothChooser impl."

This is a reland of 6a337f19713e049cd42969b0c909c59aff4146cd

This previous change caused tests to fail because of a Mojo validation
error, which is now taken care of by allowing the Bluetooth tests to
use the path to the generated Mojom files.

Design doc:
https://docs.google.com/document/d/1XFl_4ZAgO8ddM6U53A9AfUuZeWgJnlYD5wtbXqEpzeg

Original change's description:

bluetooth: FakeBluetoothChooser impl.

Implements the interfaces that FakeBluetoothChooser overrides. The
mojom::FakeBluetoothChooser overrides are implemented by running
|event_handler_| with the appropriate arguments. The BluetoothChooser
overrides do nothing at the moment, since the base class is only meant
to update the chooser user interface.

This change also begins to partially convert a Bluetooth chooser test to test
the interface and deletes the temporary tests that were created to test this
API.

This change reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a, which
reverted the original change. The original change caused the
new-scan-device-added.html test to fail because of a Mojo validation error
resulting from not updating the
third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js
file needed by the test.

Bug: 719827, 719826, 824704, 826787
Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527
Reviewed-on: https://chromium-review.googlesource.com/985195
Commit-Queue: Ovidio Henriquez \<[e-mail]>
Reviewed-by: Giovanni Ortuño Urquidi \<[e-mail]>
Reviewed-by: Daniel Cheng \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#546729}

Bug: 719827, 719826, 824704, 826787
Change-Id: If63a681becbb2ac0f646a11ea20b1db18d42395d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/986593
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez \<[e-mail]>
Reviewed-by: John Abd-El-Malek \<[e-mail]>
Reviewed-by: Giovanni Ortuño Urquidi \<[e-mail]>
Reviewed-by: Daniel Cheng \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#655081}

TBR=[e-mail],[e-mail],[e-mail],[e-mail]

Change-Id: Iacc0cf4b10969099aac34eb6eeef067f4fc8e191
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 719827, 719826, 824704, 826787
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588241
Reviewed-by: Dominik Röttsches \<[e-mail]>
Commit-Queue: Dominik Röttsches \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#655150}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=53bc7fd5980804b564e7eb585b681b3f690f07c1

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf71c065af17a2c2a7f1bfe0d43da0e1c4fc7f85

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Failed to get results from try push

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/949404d517a9
[wpt PR 16604] - Revert "Reland "bluetooth: FakeBluetoothChooser impl."", a=testonly

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/949404d517a9