Closed Bug 1550328 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 16629 - Always use physical coordinates for visual rects

Categories

(Core :: Layout, defect, P4)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16629 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16629
Details from upstream follow.

Xianzhu Wang <wangxianzhu@chromium.org> wrote:

Always use physical coordinates for visual rects

  • Let MapToVisualRectInAncestorSpace() always treat the input rect as
    in pure physical coordinates. Previously the input was inconsistent:
    pure physical for boxes, and flipped for inlines.

  • This makes it clear that all visual rects, regardless of their
    coordinates spaces, are in physical coordinates.

  • This reduces unnecessary back and forth flipping in LayoutNG which
    is already using physical coordinates in inline layout.

Bug: 941228
Change-Id: I10e16c5e7833e94a615e4dd18aa3141512b8e9e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568619
Reviewed-by: Chris Harrelson \<chrishtr@chromium.org>
Reviewed-by: Koji Ishii \<kojii@chromium.org>
Reviewed-by: Stefan Zager \<szager@chromium.org>
Commit-Queue: Xianzhu Wang \<wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656051}

Component: web-platform-tests → Layout
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/209e5010c820 [wpt PR 16629] - Always use physical coordinates for visual rects, a=testonly

https://hg.mozilla.org/mozilla-central/rev/209e5010c820

Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.