1550361 - [wpt-sync] Sync PR 16617 - Reland "Reland "bluetooth: FakeBluetoothChooser impl.""

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 16617 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16617
Details from upstream follow.

Ovidio Henriquez <[e-mail]> wrote:

Reland "Reland "bluetooth: FakeBluetoothChooser impl.""

This is a reland of cb85732cb3be7cf442e5c3afe6a3625f7edee10b

The previous change caused the WebKit Linux Trusty ASAN trybot to fail
because the FakeBluetoothChooser mojom JS file was not included when the
blink_web_tests_exparchive target was isolated.

Bug: 957867
TBR=[e-mail]

Original change's description:

Reland "bluetooth: FakeBluetoothChooser impl."

This is a reland of 6a337f19713e049cd42969b0c909c59aff4146cd

This previous change caused tests to fail because of a Mojo validation
error, which is now taken care of by allowing the Bluetooth tests to
use the path to the generated Mojom files.

Design doc:
https://docs.google.com/document/d/1XFl_4ZAgO8ddM6U53A9AfUuZeWgJnlYD5wtbXqEpzeg

Original change's description:

bluetooth: FakeBluetoothChooser impl.

Implements the interfaces that FakeBluetoothChooser overrides. The
mojom::FakeBluetoothChooser overrides are implemented by running
|event_handler_| with the appropriate arguments. The BluetoothChooser
overrides do nothing at the moment, since the base class is only meant
to update the chooser user interface.

This change also begins to partially convert a Bluetooth chooser test to test
the interface and deletes the temporary tests that were created to test this
API.

This change reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a, which
reverted the original change. The original change caused the
new-scan-device-added.html test to fail because of a Mojo validation error
resulting from not updating the
third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js
file needed by the test.

Bug: 719827, 719826, 824704, 826787
Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527
Reviewed-on: https://chromium-review.googlesource.com/985195
Commit-Queue: Ovidio Henriquez \<[e-mail]>
Reviewed-by: Giovanni Ortuño Urquidi \<[e-mail]>
Reviewed-by: Daniel Cheng \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#546729}

Bug: 719827, 719826, 824704, 826787
Change-Id: If63a681becbb2ac0f646a11ea20b1db18d42395d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/986593
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez \<[e-mail]>
Reviewed-by: John Abd-El-Malek \<[e-mail]>
Reviewed-by: Giovanni Ortuño Urquidi \<[e-mail]>
Reviewed-by: Daniel Cheng \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#655081}

Bug: 719827, 719826, 824704, 826787
Change-Id: Iaddf24a659573d3815c9c004f6fb05a41c446616
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589845
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez \<[e-mail]>
Reviewed-by: Daniel Cheng \<[e-mail]>
Reviewed-by: John Abd-El-Malek \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#655869}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e732fc6187d928a3a5b60995551706bcdcef4e7

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed0744c32a33
[wpt PR 16617] - Reland "Reland "bluetooth: FakeBluetoothChooser impl."", a=testonly

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/ed0744c32a33