1550401 - Report OOM size when StringParam::GetString (JNIEnv->NewString return nullptr) is failure

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P2)

Description

[Makoto Kato [:m_kato]]

All JNI Exception with java.lang.OutOfMemoryError calls NS_ABORT_OOM(0). But a lot of this crashes (https://crash-stats.mozilla.com/signature/?signature=java.lang.OutOfMemoryError) is StringParam::GetString. So I would like to know allocation size of OOM.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1550401 - Report OOM size when StringParam::GetString is failure.

Actually, all JNI Exceptions with java.lang.OutOfMemoryError call
NS_ABORT_OOM(0). But JNIEnv::NewString in StringParam::GetString can know
OOM size when returning nullptr. So call NS_ABORT_OOM directly when
NewString is failure.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6280c120acca
Report OOM size when StringParam::GetString is failure. r=geckoview-reviewers,snorp

Comment 3

[Chris Peterson [:cpeterson]]

We should consider uplifting this OOM report to GV 68 Beta because 68 is the version Fenix MVP will ship.

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6280c120acca

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 9064672 [details]
Bug 1550401 - Report OOM size when StringParam::GetString is failure.

Beta/Release Uplift Approval Request

• User impact if declined: When OOM occurs, gecko crashes, then we submit crash data to socorro with OOM size. But when StringParam::GetString is failure (most situation is OOM when we use JNI API), we don't report OOM size even if OOM.
  To analyze this, I would like to report OOM size correctly at this situation.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Even not landing this, Gecko crash with 0 byte OOM. After landing this, we report correct OOM size.
• String changes made/needed: no

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9064672 [details]
Bug 1550401 - Report OOM size when StringParam::GetString is failure.

fix crash annotation for some android OOMs, approved for 68.0b7

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/eeb4df23fecc