1550437 - Update spinner in the About dialog is not animating anymore during an update download

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Itiel]

This started about a month ago.

STR:

1. Run a not-so-up-to-date Nightly build
2. Open menu > Help > About Nightly

During the downloading of the update, you'll see the spinner "stuck" and not animating (note that at times it won't appear at all).

Comment 1

[Itiel]

Not sure how to bisect using Mozregression, because it sets a policy to disable updates.
Is there a way to disable this policy pre (or during) bisection?

Comment 2

[Alice0775 White]

I can reproduce the issue on Nightly68 Windows10.
I tried with manually downloading from tools.taskcluster.net/index/gecko.v2 and spoofing update channel.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=402c24bed3464222e62965b67142f9ea3a92e48e&tochange=a0dcfd3d82f2f8c2407afbb45de34d455156a048

Suspect: f5dd833c3b60b3365d2c49d930748e33a22651b6 Will Hawkins — Bug 1354913: Fix nsDeckFrame, nsImageBoxFrame and nsImageFrame so that nsDeckFrame does not tick the refresh driver when its child images are animated and hidden. r=aosmond

Comment 3

[Alice0775 White]

Will Hawkins,
Your patch seems to cause the regression. Can you please look into this?

Comment 4

[Julien Cristau [:jcristau] (back April 22)]

Will do you think you'll get to this in time for 68?

Comment 5

[Will Hawkins]

Sorry for not responding until now, what is the deadline for 68?

Comment 6

[Julien Cristau [:jcristau] (back April 22)]

68 is beta now, and about 5 weeks away from RC week.

Comment 7

[Will Hawkins]

I am working on this now.

Comment 8

[Will Hawkins]

There is a patch ready for this and I have tested. Alice0775 White do you build from source and, if so, do you want to test this in your setup?

Comment 9

[Will Hawkins]

Attachment: Bug 1550437: Animate throbber when download is updating.

Comment 10

[Alice0775 White]

(In reply to Will Hawkins from comment #8)

There is a patch ready for this and I have tested. Alice0775 White do you
build from source and, if so, do you want to test this in your setup?

How can I simulate update process(download) using the local build?

Comment 11

[Will Hawkins]

(In reply to Alice0775 White from comment #10)

(In reply to Will Hawkins from comment #8)

There is a patch ready for this and I have tested. Alice0775 White do you
build from source and, if so, do you want to test this in your setup?

How can I simulate update process(download) using the local build?

Here's how I did it? Not sure if this is the /best/ way, but it seemed to work for me.

diff --git a/toolkit/mozapps/update/UpdateService.jsm b/toolkit/mozapps/update/UpdateService.jsm
--- a/toolkit/mozapps/update/UpdateService.jsm
+++ b/toolkit/mozapps/update/UpdateService.jsm
@@ -3476,6 +3476,8 @@ Checker.prototype = {
       if (!url) {
         return;
       }
+      url =
+      "https://aus5.mozilla.org/update/6/Firefox/69.0a1/20190604212047/Linux_x86_64-gcc3/en-US/nightly/Linux%204.15.0-50-generic%20(GTK%203.22.30%2Clibpulse%2011.1.0)/ISET:SSE4_2,MEM:31808/default/default/update.xml?force=1"
 
       this._request = new XMLHttpRequest();
       this._request.open("GET", url, true);

Comment 12

[Alice0775 White]

Umm, Update process(downloading) would not start.
Sorry, I cannot.
I think it would be better to make a try build or an ordinary Nightly build.

Comment 13

[Will Hawkins]

Okay, I'm not really sure what you mean ...

You are not able to build locally?

or

You are not able to apply that patch for some reason?

If you can't build locally, no problem! I will get the code into shape and let you know when you can test nightly to make sure that everything is fiex.

Thanks for your help!
Will

Comment 14

[Francesco Lodolo [:flod]]

Comment on attachment 9070030 [details]
Bug 1550437: Animate throbber when download is updating.

Please don't flag multiple people in multiple places ;-)

Comment 15

[Will Hawkins]

(In reply to Francesco Lodolo [:flod] from comment #14)

Comment on attachment 9070030 [details]
Bug 1550437: Animate throbber when download is updating.

Please don't flag multiple people in multiple places ;-)
Very sorry! I have no idea how these Bugzilla notifications interact with Phabricator. I will make sure not to do it again!

Comment 16

[Will Hawkins]

Attachment: Bug 1550437: Make sure that About dialog animates the throbber. r=aosmond,jfkthame

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/640fcc4d6787
Make sure that About dialog animates the throbber. r=aosmond

Comment 18

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/640fcc4d6787

Comment 19

[Will Hawkins]

Itiel,

I have confirmed that this update fixes the problem. Can you verify that it looks okay to you? The fix should be in Nightly after June 12th.

Thank you for reporting the problem! I hope that this fixes it!

Will

Comment 20

[Itiel]

(In reply to Will Hawkins from comment #19)

Itiel,

I have confirmed that this update fixes the problem. Can you verify that it looks okay to you? The fix should be in Nightly after June 12th.

Thank you for reporting the problem! I hope that this fixes it!

Will

Working great now, thanks!
Marking as VERIFIED FIXED.

Comment 21

[Will Hawkins]

Comment on attachment 9071111 [details]
Bug 1550437: Make sure that About dialog animates the throbber. r=aosmond,jfkthame

Beta/Release Uplift Approval Request

• User impact if declined: The throbber does not show/animate in the About window when Firefox is downloading/processing an update.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This fix has been verified by the original reporter to have worked. Most users will not see this animation change. It is in the About window and only visible when that screen is open and there is an update available.
• String changes made/needed: None

Comment 22

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9071111 [details]
Bug 1550437: Make sure that About dialog animates the throbber. r=aosmond,jfkthame

new regression in 68, verified in nightly, approved for 68.0b11

Comment 23

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e56d843335ef

Comment 24

[Timea Cernea [:tbabos][inactive]]

Waiting for the official update to Beta 68.0b12 to verify this one in the About Nightly window. Leaving the NI? for me to remember

Comment 25

[Timea Cernea [:tbabos][inactive]]

Verified fixed on latest Beta 68.0b12 on Windows 10, Mac OS 10.14 and Ubuntu 18.04.
Updating from beta11 to beta12 will display the spinner correctly.