Closed Bug 1550438 Opened 6 years ago Closed 6 years ago

Return-to-AMO strings need to be formatted

Categories

(Firefox :: Messaging System, defect, P1)

Product:
Firefox
Component:
Messaging System
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 68
Iteration:
68.4 - Apr 29 - May 12
Tracking Flags:
Tracking Status
firefox68 --- verified

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

(Keywords: github-merged)

Attachments

(2 files)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5012
52 bytes, text/x-github-pull-request
Details | Review
Postfix Screenshot
94.21 KB, image/png
Details
Assignee: andrei.br92 → edilee
Iteration: --- → 68.4 - Apr 29 - May 12
Keywords: github-merged
Blocks: 1550883

https://hg.mozilla.org/mozilla-central/rev/a07d7f8f53ca

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

I see that Vlad originally verified the Return to AMO feature, so not sure if it should be the same person verifying this bug. Sorry for the quick bug title / description, but we needed to fix it ASAP for uplift as this was a pretty bad bug completely breaking Return to AMO as per the "before" screenshot in https://github.com/mozilla/activity-stream/pull/5012 ! :(

Flags: needinfo?(vlad.jiman)
Flags: needinfo?(mcoman)
Flags: needinfo?(cmuresan)

Verified as fixed following the steps from https://gist.github.com/pdehaan/71028fb23b3f3d36f8dc55a6cfd2643e aand using Latest Firefox Nightly on Windows 10x64.

I will attach a post fix screenshot.

Please let us know if any additional testing is needed from us.

Status: RESOLVED → VERIFIED
Flags: needinfo?(vlad.jiman)
Flags: needinfo?(mcoman)
Flags: needinfo?(cmuresan)
Attached image Postfix Screenshot —
Component: Activity Streams: Newtab → Messaging System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: