Closed Bug 1550504 Opened 7 months ago Closed 6 months ago

Disable slow frames logging in about:support by default

Categories

(Core :: Graphics: WebRender, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We don't need this information about default, except for those who opt into it via the pref.

Assignee: nobody → aosmond
Status: NEW → ASSIGNED
Priority: -- → P3
Blocks: slow-frames
Type: defect → task
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2c6cc61a9f2
Add pref to allow slow frames logging, disabled by default. r=jrmuizel
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Could this be a low-risk uplift candidate to prevent the risk of publicly revealing a visited URL by mistake? Some users might just provide their about:support output without reading it.

It's in 68, and unless there's a dot release for 67 it's unlikely to get into that release. But yeah, probably worth nominating for uplift anyway in case there's a dot release. Andrew, want to request uplift?

Flags: needinfo?(aosmond)

Comment on attachment 9063800 [details]
Bug 1550504 - Add pref to allow slow frames logging, disabled by default.

Beta/Release Uplift Approval Request

  • User impact if declined: For users with WebRender enabled, their about:support page may contain sensitive URL data for the slowest pages they visit. If there is another point release, it would be good to include this.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It just adds a pref which stops logging data for about:support. It is very simple/straightforward.
  • String changes made/needed: None
Flags: needinfo?(aosmond)
Attachment #9063800 - Flags: approval-mozilla-release?
Flags: qe-verify-

Comment on attachment 9063800 [details]
Bug 1550504 - Add pref to allow slow frames logging, disabled by default.

P3, edge case that may affect a tiny % of our release population and we want to keep 67.0.2 at a minimum of uplifts as we are well into the 67 cycle, I think it an ride the 68 train.

Attachment #9063800 - Flags: approval-mozilla-release? → approval-mozilla-release-
You need to log in before you can comment on or make changes to this bug.