Disable slow frames logging in about:support by default
Categories
(Core :: Graphics: WebRender, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: aosmond, Assigned: aosmond)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
47 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-release-
|
Details | Review |
We don't need this information about default, except for those who opt into it via the pref.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Pushed by aosmond@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a2c6cc61a9f2 Add pref to allow slow frames logging, disabled by default. r=jrmuizel
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
|
|
||
Comment 4•5 years ago
|
||
Could this be a low-risk uplift candidate to prevent the risk of publicly revealing a visited URL by mistake? Some users might just provide their about:support output without reading it.
|
||
Comment 5•5 years ago
|
||
It's in 68, and unless there's a dot release for 67 it's unlikely to get into that release. But yeah, probably worth nominating for uplift anyway in case there's a dot release. Andrew, want to request uplift?
|
|
Assignee | |
Comment 6•5 years ago
|
||
Comment on attachment 9063800 [details]
Bug 1550504 - Add pref to allow slow frames logging, disabled by default.
Beta/Release Uplift Approval Request
- User impact if declined: For users with WebRender enabled, their about:support page may contain sensitive URL data for the slowest pages they visit. If there is another point release, it would be good to include this.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): It just adds a pref which stops logging data for about:support. It is very simple/straightforward.
- String changes made/needed: None
|
||
Updated•5 years ago
|
|
||
Comment 7•5 years ago
|
||
Comment on attachment 9063800 [details]
Bug 1550504 - Add pref to allow slow frames logging, disabled by default.
P3, edge case that may affect a tiny % of our release population and we want to keep 67.0.2 at a minimum of uplifts as we are well into the 67 cycle, I think it an ride the 68 train.
Description
•