1550518 - mach xpcshell-test should support the --headless argument

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

STEPS TO REPRODUCE: Run "mach test --headless dom/push"

EXPECTED RESULTS: Runs all the dom/push tests (mochitest and xpcshell), with the mochitests running headless.

ACTUAL RESULTS: Runs the mochitests headless, then errors out with:

  mach: error: unrecognized arguments for xpcshell-test: '--headless'

Comment 1

[Geoff Brown [:gbrown]]

:ahal - Do you have thoughts or a vision for the generic issue here? Should all the harnesses recognize the same options, or should 'mach test' filter options, or ...?

Comment 2

[Andrew Halberstadt [:ahal]]

I don't think all harnesses should support all options (that would get very messy very fast). But in this case since xpcshell is headless anyway and since --headless is a pretty common argument to want to pass, I think it's fine to add this in a one-off manner (with help=argparse.SUPPRESS).

But yeah, longer term I think we need to do some filtering in |mach test|. Maybe if a harness doesn't support an arg we print a warning that we aren't passing it in. I'd also love if there were a base argument parser that all harnesses used where we could define common args (with the ability to "mix in" groups of args).

Comment 3

[Matthew N. [:MattN]]

This annoys me almost everyday as I'm working in a component with 2 flavours of mochitest plus xpcshell-test and I can't use a single command to run all tests.

Comment 4

[Matthew N. [:MattN]]

Attachment: Bug 1550518 - Add --headless support for xpcshell-test. r=ahal

Entries in the xpcshell.ini manifest override the default specified on the command line.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6b3c5580dc2
Add --headless support for xpcshell-test. r=gbrown

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b6b3c5580dc2