1550545 - Some small XPIDL cleanups

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

• Most of the isScriptable methods in xpidl.py are unused.
• mk_method unbundles some fields of attributes/methods which makes the code messy.
• Instead of storing notxpcom and hidden in XPT, we could just fold notxpcom into hidden, which makes things a little simpler.
• We store a scriptable flag for interfaces in XPT, but we only generate XPT for scriptable interfaces, so it isn't read anywhere.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1550545, part 1 - Remove the unused isScriptable methods.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1550545, part 2 - Pass arguments to mk_method bundled up.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1550545, part 3 - Move the logic for notxpcom implying hidden into jsonxpt.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Bug 1550545, part 4 - Don't generate the scriptable flag in XPT files.

We never emit an XPT for an interface that is not scriptable, so this
flag is never used.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11117f34b30e
part 1 - Remove the unused isScriptable methods. r=nika
https://hg.mozilla.org/integration/autoland/rev/d9144ab0231e
part 2 - Pass arguments to mk_method bundled up. r=nika
https://hg.mozilla.org/integration/autoland/rev/8095cb5a0964
part 3 - Move the logic for notxpcom implying hidden into jsonxpt. r=nika
https://hg.mozilla.org/integration/autoland/rev/e93a97c6e708
part 4 - Don't generate the scriptable flag in XPT files. r=nika

Comment 6

[Andrew McCreight [:mccr8]]

Hmm looks like we run linters on Python now, so I'm going to turn the tree orange because of an extra blank line.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9cc74682a430
Fix linting failure. r=nbeleuzu CLOSED TREE

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/11117f34b30e
https://hg.mozilla.org/mozilla-central/rev/d9144ab0231e
https://hg.mozilla.org/mozilla-central/rev/8095cb5a0964
https://hg.mozilla.org/mozilla-central/rev/e93a97c6e708
https://hg.mozilla.org/mozilla-central/rev/9cc74682a430

Comment 9

[Andrew McCreight [:mccr8]]

Thanks for the fix!