Closed Bug 1550559 Opened 1 year ago Closed 1 year ago

Convert findbar XUL textbox to HTML input

Categories

(Toolkit :: Find Toolbar, task)

68 Branch
task
Not set

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox68 --- wontfix
firefox69 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

Details

Attachments

(1 file)

No description provided.
Component: General → Find Toolbar
Product: Firefox → Toolkit
Depends on: 1550561
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c8057f34f281
Convert findbar XUL textbox to HTML input. r=bgrins
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/30ee2053caf2
Convert findbar XUL textbox to HTML input. r=bgrins

Backed out changeset 30ee2053caf2 (bug 1550559) for chrome failures at docshell/test/chrome/test_bug298622.xul

Backout: https://hg.mozilla.org/integration/autoland/rev/b64e1b70da6cd03af4bb11c394371fece743f108

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=246651454&revision=30ee2053caf27c743cb02d8355da879ec8310465

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=246651795&repo=autoland&lineNumber=56013

[task 2019-05-15T18:46:29.340Z] 18:46:29 INFO - TEST-PASS | docshell/test/chrome/test_bug298622.xul | Findfield status attribute should not have been 'notfound' after Find
[task 2019-05-15T18:46:29.341Z] 18:46:29 INFO - Buffered messages finished
[task 2019-05-15T18:46:29.343Z] 18:46:29 INFO - TEST-UNEXPECTED-FAIL | docshell/test/chrome/test_bug298622.xul | uncaught exception - TypeError: gFindBar._findField.inputField is undefined at testIterator@chrome://mochitests/content/chrome/docshell/test/chrome/bug298622_window.xul:87:7
[task 2019-05-15T18:46:29.343Z] 18:46:29 INFO - nextTest@chrome://mochitests/content/chrome/docshell/test/chrome/bug298622_window.xul:24:13
[task 2019-05-15T18:46:29.343Z] 18:46:29 INFO - waitForTrue/intervalid<@chrome://mochitests/content/chrome/docshell/test/chrome/docshell_helpers.js:410:26
[task 2019-05-15T18:46:29.344Z] 18:46:29 INFO - setInterval handlerwaitForTrue@chrome://mochitests/content/chrome/docshell/test/chrome/docshell_helpers.js:397:5
[task 2019-05-15T18:46:29.345Z] 18:46:29 INFO - testIterator@chrome://mochitests/content/chrome/docshell/test/chrome/bug298622_window.xul:80:7
[task 2019-05-15T18:46:29.345Z] 18:46:29 INFO - nextTest@chrome://mochitests/content/chrome/docshell/test/chrome/bug298622_window.xul:24:13
[task 2019-05-15T18:46:29.345Z] 18:46:29 INFO -
[task 2019-05-15T18:46:29.346Z] 18:46:29 INFO - simpletestOnerror@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1665:24
[task 2019-05-15T18:46:29.346Z] 18:46:29 INFO - OnErrorEventHandlerNonNull
@chrome://mochitests/content/chrome/docshell/test/chrome/docshell_helpers.js:7:3
[task 2019-05-15T18:46:29.346Z] 18:46:29 INFO - GECKO(4454) | JavaScript error: chrome://mochitests/content/chrome/docshell/test/chrome/bug298622_window.xul, line 87: TypeError: gFindBar._findField.inputField is undefined
[task 2019-05-15T18:46:29.347Z] 18:46:29 INFO - GECKO(4454) | MEMORY STAT | vsize 3017MB | residentFast 406MB | heapAllocated 154MB

Flags: needinfo?(ntim.bugs)
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2a9a034e1b6a
Convert findbar XUL textbox to HTML input. r=bgrins

Backed out for perma fails on test_bug360437.xul

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&searchStr=macosx1010-64%2Cdebug%2Cmochitests%2Cwithout%2Ce10s%2Ctest-macosx1010-64%2Fdebug-mochitest-chrome-1proc-3%2Cm-1proc%28c3%29&revision=2a9a034e1b6a38cba33ba668704cce7ad7a04cd3&selectedJob=246790559

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=246790559&repo=autoland&lineNumber=12239

12:10:13 INFO - TEST-START | toolkit/content/tests/chrome/test_bug360437.xul
12:10:13 INFO - GECKO(2596) | ++DOMWINDOW == 67 (0x12cf5b000) [pid = 2596] [serial = 105] [outer = 0x12de176a0]
12:10:13 INFO - GECKO(2596) | ++DOCSHELL 0x12e258800 == 23 [pid = 2596] [id = {7f976578-1aa6-044d-af2c-70b2e8828711}]
12:10:13 INFO - GECKO(2596) | ++DOMWINDOW == 68 (0x129166100) [pid = 2596] [serial = 106] [outer = 0x0]
12:10:13 INFO - GECKO(2596) | ++DOMWINDOW == 69 (0x12dbc6c00) [pid = 2596] [serial = 107] [outer = 0x129166100]
12:10:13 INFO - GECKO(2596) | ++DOCSHELL 0x12e25f800 == 24 [pid = 2596] [id = {df5705b2-b75a-974d-bfc1-b277bc276cfd}]
12:10:13 INFO - GECKO(2596) | ++DOMWINDOW == 70 (0x129125880) [pid = 2596] [serial = 108] [outer = 0x0]
12:10:13 INFO - GECKO(2596) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /var/folders/sp/d7q9cq_54lsgfl1twn6wm1f000000x/T/tmpAn_OUQ.mozrunner/runtests_leaks_tab_pid2606.log
12:10:13 INFO - GECKO(2596) | ++DOMWINDOW == 71 (0x12dbcf400) [pid = 2596] [serial = 109] [outer = 0x129125880]
12:10:13 INFO - GECKO(2596) | ++DOMWINDOW == 72 (0x12dbd0000) [pid = 2596] [serial = 110] [outer = 0x129125880]
12:10:13 INFO - GECKO(2596) | ++DOMWINDOW == 73 (0x1269c2c00) [pid = 2596] [serial = 111] [outer = 0x129125880]
12:10:13 INFO - TEST-INFO | started process screencapture
12:10:14 INFO - TEST-INFO | screencapture: exit 0
12:10:14 INFO - Buffered messages logged at 12:10:13
12:10:14 INFO - Starting test with browser 'content'
12:10:14 INFO - TEST-PASS | toolkit/content/tests/chrome/test_bug360437.xul | Find field isn't focused
12:10:14 INFO - Buffered messages finished
12:10:14 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_bug360437.xul | Input Element isn't focused - {} == {}
12:10:14 INFO - resource://testing-common/content-task.js line 59 > eval:null:4
12:10:14 INFO - resource://testing-common/content-task.js:null:60
12:10:14 INFO - TEST-PASS | toolkit/content/tests/chrome/test_bug360437.xul | Focus was stolen from a chrome element
12:10:14 INFO - Starting test with browser 'content-remote'
12:10:14 INFO - GECKO(2596) | ++DOCSHELL 0x116ebc800 == 1 [pid = 2606] [id = {31ea1935-7e25-9a46-8eca-32fd99e20dcf}]
12:10:14 INFO - GECKO(2596) | ++DOMWINDOW == 1 (0x11dd3e020) [pid = 2606] [serial = 1] [outer = 0x0]
12:10:14 INFO - GECKO(2596) | [Child 2606, Main Thread] WARNING: No active window: file /builds/worker/workspace/build/src/js/xpconnect/src/XPCJSContext.cpp, line 662
12:10:14 INFO - GECKO(2596) | ++DOMWINDOW == 2 (0x116e88c00) [pid = 2606] [serial = 2] [outer = 0x11dd3e020]
12:10:14 INFO - GECKO(2596) | ++DOMWINDOW == 3 (0x11ddaa400) [pid = 2606] [serial = 3] [outer = 0x11dd3e020]
12:10:14 INFO - TEST-PASS | toolkit/content/tests/chrome/test_bug360437.xul | Find field isn't focused
12:10:14 INFO - Not taking screenshot here: see the one that was previously logged
12:10:14 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_bug360437.xul | Input Element isn't focused - {} == {}
12:10:14 INFO - resource://testing-common/content-task.js line 59 > eval:null:4
12:10:14 INFO - resource://testing-common/content-task.js:null:60
12:10:14 INFO - TEST-PASS | toolkit/content/tests/chrome/test_bug360437.xul | Focus was stolen from a chrome element
12:10:14 INFO - GECKO(2596) | MEMORY STAT | vsize 5488MB | residentFast 387MB | heapAllocated 153MB
12:10:14 INFO - GECKO(2596) | JavaScript error: resource://gre/modules/FinderIterator.jsm, line 574: TypeError: can't access dead object
12:10:14 INFO - TEST-OK | toolkit/content/tests/chrome/test_bug360437.xul | took 1559ms
12:10:14 INFO - GECKO(2596) | [Child 2606, Main Thread] WARNING: nsAppShell::Exit() called redundantly: file /builds/worker/workspace/build/src/widget/cocoa/nsAppShell.mm, line 725
12:10:14 INFO - GECKO(2596) | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
12:10:14 INFO - GECKO(2596) | ++DOMWINDOW == 74 (0x1269c0000) [pid = 2596] [serial = 112] [outer = 0x12de176a0]

Backout: https://hg.mozilla.org/integration/autoland/rev/1ad490784e09e55189385096091ca8c1ae815bbb

Flags: needinfo?(ntim.bugs)
Keywords: checkin-needed

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a3228e7cd520
Convert findbar XUL textbox to HTML input. r=bgrins

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Assignee: nobody → ntim.bugs
Regressions: 1563529
You need to log in before you can comment on or make changes to this bug.