1550566 - Retrieve `deviceID` parameter from FxA metrics endpoint and append as additional query parameter for FxA flows

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Leif Oines [:loines]]

We discovered that in some cases there is a breakage in funnel analyses when tracing a user's flow starting on about:welcome (and other reliers) through all the steps of the FxA registration login funnels.

The tl;dr is that you should now GET an additional deviceId parameter from our metrics endpoint and append it to the FxA url as a device_id query parameter. e.g.:

https://accounts.firefox.com/signin?service=sync&action=email&context=fx_desktop_v3&entrypoint=activity-stream-firstrun&style=trailhead&utm_source=activity-stream&utm_campaign=firstrun&utm_medium=referral&utm_term=trailhead-join-card&flow_id=0c58219ac453b5bdffa82aa07b975b5b9fa9b4af6b1a489cdf59ed1d04493635&flow_begin_time=1557331208500&device_id={a_string}

(No changes to other parameters, just this addition.)

However, on the FxA end, we will need to merge and deploy this PR before you will be able to start retrieving it from us. I will update this bug once that's done.

Sorry to make more work here, IIUC it should be a minor fix. We didn't discover that this was needed until after you merged this.

lmk if something doesn't make sense here.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

Sounds pretty straightforward. Looks like the PR is merged, let me know when it's deployed so I can test it. Thanks!

Comment 2

[Phil Booth [:pb]]

The FxA part of this is in production now.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5015

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/a07d7f8f53ca

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this issue with the latest Firefox Nightly (68.0a1 Build ID - 20190513082256) installed, on Windows 10 x64, Arch Linux and Mac 10.14.4. Now, the "deviceID" parameter is added as an additional query parameter for FxA flows.

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-release/rev/df853c362664989e025d1206b59c37c435186a91