1550606 - Intermittent /x-frame-options/sameorigin.sub.html | `XFO: SAMEORIGIN` allows same-origin nested in same-origin framing. - assert_equals: expected "Loaded" but got "Failed"

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: cbrindusan [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=245610084&repo=autoland
Full log: https://queue.taskcluster.net/v1/task/SJa8CzzTQWe2QdiAteNDOw/runs/0/artifacts/public/logs/live_backing.log

---

[task 2019-05-09T20:53:35.307Z] 20:53:35 INFO - TEST-START | /x-frame-options/sameorigin.sub.html
[task 2019-05-09T20:53:35.314Z] 20:53:35 INFO - Closing window 12884901889
[task 2019-05-09T20:53:35.411Z] 20:53:35 INFO - PID 24366 | -----------------------------------------------------
[task 2019-05-09T20:53:35.413Z] 20:53:35 INFO - PID 24366 | Suppressions used:
[task 2019-05-09T20:53:35.414Z] 20:53:35 INFO - PID 24366 | count bytes template
[task 2019-05-09T20:53:35.415Z] 20:53:35 INFO - PID 24366 | 28 864 nsComponentManagerImpl
[task 2019-05-09T20:53:35.417Z] 20:53:35 INFO - PID 24366 | 611 17713 libfontconfig.so
[task 2019-05-09T20:53:35.417Z] 20:53:35 INFO - PID 24366 | 1 29 libglib-2.0.so
[task 2019-05-09T20:53:35.418Z] 20:53:35 INFO - PID 24366 | -----------------------------------------------------
[task 2019-05-09T20:53:36.474Z] 20:53:36 INFO - PID 24366 | -----------------------------------------------------
[task 2019-05-09T20:53:36.474Z] 20:53:36 INFO - PID 24366 | Suppressions used:
[task 2019-05-09T20:53:36.477Z] 20:53:36 INFO - PID 24366 | count bytes template
[task 2019-05-09T20:53:36.478Z] 20:53:36 INFO - PID 24366 | 28 864 nsComponentManagerImpl
[task 2019-05-09T20:53:36.478Z] 20:53:36 INFO - PID 24366 | 611 17713 libfontconfig.so
[task 2019-05-09T20:53:36.478Z] 20:53:36 INFO - PID 24366 | 1 29 libglib-2.0.so
[task 2019-05-09T20:53:36.480Z] 20:53:36 INFO - PID 24366 | -----------------------------------------------------
[task 2019-05-09T20:53:36.706Z] 20:53:36 INFO -
[task 2019-05-09T20:53:36.706Z] 20:53:36 INFO - TEST-PASS | /x-frame-options/sameorigin.sub.html | XFO: SAMEORIGIN allows same-origin framing.
[task 2019-05-09T20:53:36.706Z] 20:53:36 INFO - TEST-UNEXPECTED-FAIL | /x-frame-options/sameorigin.sub.html | XFO: SAMEORIGIN allows same-origin nested in same-origin framing. - assert_equals: expected "Loaded" but got "Failed"

Comment 1

[Intermittent Failures Robot]

17 failures in 821 pushes (0.021 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 17

Platform breakdown:

• linux64: 14
• linux64-shippable: 2
• osx-10-10: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1550606&startday=2019-05-09&endday=2019-05-09&tree=all

Comment 2

[Andreea Pavel [:apavel]]

Retrigger range: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Casan%2Cweb%2Cplatform%2Ctests%2Ctest-linux64-asan%2Fopt-web-platform-tests-e10s-3%2Cw%28wpt3%29&tochange=7fa8e33635fcd787ff275d92fd4e9c8df6127d78&fromchange=c75e0b9c3a1cbe4956e3cfd384ab0321a0d37774&selectedJob=245593392

Comment 3

[Intermittent Failures Robot]

17 failures in 4705 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 17

Platform breakdown:

• linux64: 14
• osx-10-10: 1
• linux64-shippable: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1550606&startday=2019-05-06&endday=2019-05-12&tree=all

Comment 4

[Andreea Pavel [:apavel]]

Retriggers show this is from Bug 1534012, Sean, please take a look.

Comment 5

[Sean Feng [:sefeng]]

hey apavel: Bug 1534012 got backed out, so I don't think it caused the regression?

Comment 6

[Andreea Pavel [:apavel]]

Hi Sean, I know, I saw it. There are no occurrences since the bug got backed out. However, I looked into this and you should know when fixing bug 1534012 that this is an issue that needs to be fixed too.

Comment 7

[Sean Feng [:sefeng]]

apavel: yep, thanks. I'll keep that in mind!

Comment 8

[Cristina Coroiu [:ccoroiu]]

Retriggers:
https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Casan%2Cweb%2Cplatform%2Ctests%2Ctest-linux64-asan%2Fopt-web-platform-tests-e10s-3%2Cw%28wpt3%29&tochange=55c360c47f31698fe123b0d2838d07d390048e0a&fromchange=a8f5dec91d72d4032ced008f847ead37f350193f

https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Cshippable%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-linux64-shippable%2Fopt-web-platform-tests-e10s-3%2Cw%28wpt3%29&tochange=55c360c47f31698fe123b0d2838d07d390048e0a&fromchange=a8f5dec91d72d4032ced008f847ead37f350193f

The culprit seems to be https://bugzilla.mozilla.org/show_bug.cgi?id=1534012

Sean, can you please take a look at this?

Comment 9

[Intermittent Failures Robot]

17 failures in 739 pushes (0.023 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 17

Platform breakdown:

• linux64: 12
• linux64-shippable: 4
• macosx1010-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1550606&startday=2019-05-20&endday=2019-05-20&tree=all

Comment 10

[Andreea Pavel [:apavel]]

From IRC:

sefeng> apavel|sheriffduty: ah yeah looking...I thought I fixed it, but it is flaky
5:17 PM apavel|sheriffduty: sorry about that

Comment 11

[Sean Feng [:sefeng]]

Attachment: Bug 1550606 - Fix a race condition in WPT related to postMessage r=smaug

We used to use 2 rAFs to stop the load event from racing with
onmessage event, but this was not the proper solution and it was
still racy, especially after Bug 1534012 is landed. So we fixed it
by instead letting racy postMessage to be sent, we wait for the
proper postMessage to be sent, and the test would automatically
timeout if the proper postMessage failed to sent.

Comment 12

[Sean Feng [:sefeng]]

Definitely my patch caused it. The actual problem was a buggy web platform test. The patch to fix the bug is up, and this is the try push https://treeherder.mozilla.org/#/jobs?repo=try&revision=ccc77a4b6a3be7927e888106e7b795e740222104. I'll wait for the try push result.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28a981abcc6c
Fix a race condition in WPT related to postMessage r=smaug

Comment 14

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16946 for changes under testing/web-platform/tests

Comment 15

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 16

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/28a981abcc6c

Comment 17

[Intermittent Failures Robot]

133 failures in 996 pushes (0.134 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 101
• mozilla-inbound: 10
• mozilla-central: 16
• try: 6

Platform breakdown:

• linux64: 78
• linux32: 9
• macosx1010-64: 29
• linux64-shippable: 1
• linux32-shippable: 5
• windows10-64: 1
• linux64-ccov: 2
• windows10-aarch64: 2
• linux64-qr: 2
• macosx1010-64-shippable: 2
• windows10-64-qr: 1
• windows10-64-ccov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1550606&startday=2019-05-21&endday=2019-05-21&tree=all

Comment 18

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 19

[Intermittent Failures Robot]

153 failures in 4730 pushes (0.032 failures/push) were associated with this bug in the last 7 days.

This is the #13 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 118
• mozilla-inbound: 10
• mozilla-central: 16
• try: 9

Platform breakdown:

• linux64: 91
• linux64-shippable: 5
• linux32: 9
• macosx1010-64: 31
• linux32-shippable: 5
• windows10-64: 1
• linux64-ccov: 2
• windows10-aarch64: 2
• linux64-qr: 3
• macosx1010-64-shippable: 2
• windows10-64-qr: 1
• windows10-64-ccov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1550606&startday=2019-05-20&endday=2019-05-26&tree=all