1550694 - OTR: Consider to move all strings to a single file.

Status: RESOLVED WORKSFORME

(Chat Core :: Security: OTR, defect)

Description

[Kai Engert (:KaiE:)]

Follow-up from review of bug 1518172.

Discuss if we should move all OTR strings into single dtd/properties files.

Comment 1

[Kai Engert (:KaiE:)]

Patrick, with the conversion to fluent, each pair of {dtd, properties} was merged into a combined ftl file.

Would you be OK keeping the individual files, with some of them being directly related to dialogs?

Comment 2

[Patrick Cloke [:clokep]]

For reference, bug 1550488 changed this code to use fluent.

Comment 3

[Patrick Cloke [:clokep]]

(In reply to Kai Engert (:kaie:) from comment #1)

Would you be OK keeping the individual files, with some of them being directly related to dialogs?

If each dialog usually has a separate file then that's fine.

Comment 4

[Kai Engert (:KaiE:)]

We have 7 ftl files. 4 are for OTR dialogs. 1 is for the global account prefs. So we're down to two files, and those are used by the separate OTR.jsm and OTRUI.jsm modules.

Based on Patrick's comment, IIUC this should be acceptable.