Closed Bug 1550751 Opened 4 months ago Closed 3 months ago

Optimize DivPowTwoI to not round non-truncated (bailing) divisions.

Categories

(Core :: JavaScript Engine: JIT, enhancement, P3)

x86_64
All
enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: nbp, Assigned: nbp)

References

Details

Attachments

(1 file)

While reverse-engineering our own code of x86 for divisions by known constants, I noticed that we were doing the code to round the dividend towards 0 even when we are bailout because of a non-zero remainder.

If we have a zero remainder, then there is no need to round the dividend.

Pushed by npierron@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/93d785b20f99
Skip rounding the dividend of non-truncated integer division, as already handled by a bailout. r=mgaudet
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.