Closed Bug 1550756 Opened 2 years ago Closed 2 years ago

Make system principal fall into new traffic category

Categories

(Core :: Networking, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: xeonchen, Assigned: xeonchen)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

No description provided.

ThirdPartyUtil::IsThirdPartyChannel will return true for nsHttpChannels created for system principals.

It makes network traffic such as captive portal being categorized as third party channels.
We should probably check system principal before using the value returned from nsContentUtils::IsThirdPartyWindowOrChannel.

  • add 2 category: system principals for normal/private browsing
  • P3Basic* and P3Content* are labeled incorrectly
  • add many assertions to check categories

According to the discussion in the anti-tracking engineering meeting today, we decided to land the patch even it will reset the data set. Gary, please go ahead to land and inform stakeholders (maybe on #bandwidth-telemetry channel) about this change.

Pushed by xeonchen@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/bcab46b227b6
make system principal fall into new traffic category; r=dragana

The updated categories will be:

Flags Load Type
nsIClassOfService::Leader A
w/o nsIRequest::LOAD_BACKGROUND B
w/ nsIRequest::LOAD_BACKGROUND C
Category List Category
Basic Disconnected List I
Content II
Fingerprinting III

Normal Mode

Y = 0 for system principals
Y = 1 for first party
Y = 2 for non-listed third party type

\Y\ Type A Type B Type C
Category I 3 4 5
Category II 6 7 8
Category III 9 10 11

Private Mode

Y = 12 for system principals
Y = 13 for first party
Y = 14 for non-listed third party type

\Y\ Type A Type B Type C
Category I 15 16 17
Category II 18 19 20
Category III 21 22 23

check source code for the most updated info.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Depends on: 1552431
You need to log in before you can comment on or make changes to this bug.