Closed Bug 1550807 Opened 3 years ago Closed 3 years ago

Tracelogger not outputting correct script events when baseline is enabled

Categories

(Core :: JavaScript Engine, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: denispal, Assigned: denispal)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Tracelogger is continuously disabling itself early due to bad script event id's that are being started. This problem is specific to generator JSOP RESUME opcodes, the script events that are passed in with emitTraceLoggerResume() are always garbage.

This appears to be because the baseline script is no longer loaded in the scratch1 register here: https://searchfox.org/mozilla-central/rev/b949ce10fd1d90e70a14b31dfdb72a3911d57108/js/src/jit/BaselineCompiler.cpp#5647-5656

Tracelogger is no longer functioning properly because of bad script event ids. The baselinescript load into scratch1 was accidentally removed leading garbage script ids to be passed into emitTraceLoggerResume. This fix aims to simply reload the correct value back into scratch1 before calling tracelogger.

Keywords: checkin-needed

Pushed by aciure@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/419436973f91
Load the baselinescript into scratch1 before calling emitTraceLoggerResume r=jandem

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Has Regression Range: --- → yes
Keywords: regression
You need to log in before you can comment on or make changes to this bug.