1550808 - Windows-only TV/TVg No checks run -- files in layout/reftests/w3c-css

Status: RESOLVED FIXED

(Testing :: General, defect, P2)

Description

[Geoff Brown [:gbrown]]

From https://bugzilla.mozilla.org/show_bug.cgi?id=1528471#c25:

test-verify of tests like:

layout/reftests/w3c-css/received/css-writing-modes/table-progression-vlr-002.html
layout/reftests/w3c-css/received/css-multicol/multicol-nested-002.xht
layout/reftests/w3c-css/received/css-multicol/multicol-columns-007.xht
layout/reftests/w3c-css/received/css-multicol/multicol-nested-margin-003.xht
...

fail with "No checks run", on Windows only.

Reproduced here:

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=c64cac231de30d549a1770028789f4188fc18b3d

Comment 1

[Geoff Brown [:gbrown]]

In contrast, test-verify of reftests in other directories is okay on all platforms:

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=91f7b84292439435dfd42b2373804fd84cd38e6b

Comment 2

[Geoff Brown [:gbrown]]

(In reply to Geoff Brown [:gbrown] from comment #0)

Reproduced here:

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=c64cac231de30d549a1770028789f4188fc18b3d

17:50:16     INFO - Per-test run found test layout\reftests\w3c-css\received\css-writing-modes\table-progression-vlr-002.html (reftest/gpu)
17:50:16     INFO - Per-test run found test layout\reftests\w3c-css\received\css-multicol\multicol-nested-002.xht (reftest/gpu)
...
17:52:18     INFO - Per-test suites: {'reftest': {'tests': ('tests/reftest/tests/layout/reftests/reftest.list',), 'options': ('--suite=reftest',)}}
...
17:52:38     INFO - REFTEST INFO | Reading manifest file://Z:/task_1557509489/build/tests/reftest/tests/layout/reftests/w3c-css/received\reftest.list

That looks fine...but no tests are run.

Comment 3

[Geoff Brown [:gbrown]]

The "special" characteristic of these tests is that the tests reside in a sub-directory of the location of the manifest. As a result, the path name of the specified test relative to the manifest contains a path separator, and there seems to be a mismatch between the expected and actual path separators in that path, on Windows only of course. It is unclear to me if this condition arises because of the format of the test path that TV specifies, or if this is a generic vulnerability in reftest on Windows.

Comment 4

[Geoff Brown [:gbrown]]

Attachment: Bug 1550808 - Support reftest in sub-directory of manifest location, even on Windows; r=ahal

When TV runs the reftest harness against an individual reftest, and the specified reftest
is in a sub-directory of its manifest location, the harness currently fails to run the
requested test, on Windows only. For example, the pathname in findManifest might be
"css-multicol\multicol-nested-002.xht", on Windows. Using posixpath changes pathname to
"css-multicol/multicol-nested-002.xht", regardless of platform, and that seems to work
everywhere.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76c35c245dec
Support reftest in sub-directory of manifest location, even on Windows; r=ahal

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/76c35c245dec