Closed Bug 1550858 Opened 6 months ago Closed 6 months ago

Update final final final final final actions or urls

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 69
Iteration:
69.1 - May 13 - 26
Tracking Status
firefox67 --- wontfix
firefox67.0.1 --- fixed
firefox68 + verified
firefox69 --- verified

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

(Keywords: github-merged)

Attachments

(3 files)

We might need to update at least "Tracking Protection" which currently opens up about:preferences#privacy-trackingprotection but might want to open a url instead.

The "Send Tab" URL has been updated to:
https://support.mozilla.org/kb/send-tab-firefox-desktop-other-devices

The previous URL will still redirect with a notice, but ideally we should use the canonical URL.

Depends on: 1549802
Blocks: 1550861
Priority: -- → P1
Iteration: --- → 69.1 - May 13 - 26

Do we have a cutoff date for someone to decide on the "Tracking Protection" action? We'll want to uplift to 67.0.5 ASAP for QA to sign off, and the earliest mozilla-release opens up is May 21st after 67 release.

Flags: needinfo?(jimthomas)

For send tabs sumo article, looks like there's a fr page:

https://support.mozilla.org/fr/kb/envoyer-onglet-firefox-ordinateur-autre-appareil

But it has an english video. And no de page.

And that we only do that url for en-* and others locales keep about:preferences#privacy-trackingprotection

Yes, let's use the redirect for future flexibility.

URL for en-*: https://mzl.la/ETPdefault
For non-en locales, keep about:preferences#privacy-trackingprotection

Flags: needinfo?(jimthomas)
Assignee: nobody → edilee
Blocks: 1553334
Status: NEW → RESOLVED
Closed: 6 months ago
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69

I have verified this issue with the latest Firefox Nightly (69.0a1 Build ID - 20190522152821) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the "Send Tabs" URL has been updated to "https://support.mozilla.org/kb/send-tab-firefox-desktop-other-devices" and the "Tracking Protection" one has been updated to "https://mzl.la/ETPdefault" for the en-* builds (the non-en locales are still redirecting to "about:preferences#privacy-trackingprotection").

Status: RESOLVED → VERIFIED
Blocks: 1552282

[Tracking Requested - why for this release]: Moving tracking from meta https://bugzilla.mozilla.org/show_bug.cgi?id=1552282#a669715_580382 to the 2 individual bugs that made it to 67.0.5 and 69 but not 68

Hi Ed, what's the status of this and the other bug for 68?

Flags: needinfo?(edilee)

If it doesn't need a re-review as it already landed in 69 https://hg.mozilla.org/mozilla-central/rev/365a93ecb6ee and 67 https://hg.mozilla.org/releases/mozilla-release/rev/df853c362664989e025d1206b59c37c435186a91

then I guess just the uplift request? Although I guess I'll try to poke someone for a review to avoid https://bugzilla.mozilla.org/show_bug.cgi?id=1552596#c19

Flags: needinfo?(edilee)

My confusion in bug 1552596 is that there's an open review request in phab. If it doesn't actually need review then we can just land the uplift.

Comment on attachment 9070334 [details]
Bug 1550858 - Update final final final final final actions or urls

Beta/Release Uplift Approval Request

  • User impact if declined: Wrong links when clicking on about:welcome cards
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: comment 10
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just updating the urls for a couple cards already verified on 69 and 67
  • String changes made/needed: none
Attachment #9070334 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9070334 [details]
Bug 1550858 - Update final final final final final actions or urls

new tab update for 68.0b11

Attachment #9070334 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I have verified this issue with the latest Firefox Beta (68.0b11 Build ID - 20190617172838) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the "Send Tabs" URL has been updated to "https://support.mozilla.org/kb/send-tab-firefox-desktop-other-devices" and the "Tracking Protection" one has been updated to "https://mzl.la/ETPdefault" for the en-* builds (the non-en locales are still redirecting to "about:preferences#privacy-trackingprotection").

Flags: qe-verify+
Component: Activity Streams: Newtab → Messaging System
You need to log in before you can comment on or make changes to this bug.