1550861 - Trailhead final uplift

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: We don't want this for 67.0/rcs. Will use this to track bugs blocking this uplift.

Comment 1

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked for 67.0.5

Comment 2

[Ed Lee :Mardak]

Bug 1547830 is tracking 67.0.5 and will most likely get uplifted separately from newtab related changes.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5050

Comment 4

[Ed Lee :Mardak]

Attachment: Bug 1550861 - Trailhead final uplift

Comment 5

[Ed Lee :Mardak]

Latest try with latest fix https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7003a60bb9fc26ce43778539207c6a8493fcdfd

Comment 6

[Ed Lee :Mardak]

Comment on attachment 9066210 [details]
Bug 1550861 - Trailhead final uplift

Beta/Release Uplift Approval Request

• User impact if declined: New users would get the old about:welcome experience instead of the new trailhead messaging
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Test plan: https://docs.google.com/document/d/1rYKKM3Jz4Bg-569SdAL5imj_uVKg2n3IiZjoCDgRkJg
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): This changes the default about:welcome experience for en/de/fr locales to run 2 experiments with 9 total branches, and the only way to turn them off given the first run nature is with another code change / dot release. Most of the changes that are behind the default pref have already been verified on nightly (~35 verified with ~5 more to be verified soon), and these changes are to a feature that is shown once to new users with no other dependent features, so overall the risk is lower.
• String changes made/needed: Yes, various trailhead strings were updated since initial landing and have landed on mozilla-central reviewed by flod there and here

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9066210 [details]
Bug 1550861 - Trailhead final uplift

Approved for 67.0.5, thanks.

Comment 8

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-release/rev/df853c362664989e025d1206b59c37c435186a91

Comment 9

[Ed Lee :Mardak]

I manually triggered L10n-Rpk builds:

https://treeherder.mozilla.org/#/jobs?repo=mozilla-release&searchStr=l10n&revision=df853c362664989e025d1206b59c37c435186a91

Windows builds:
de https://queue.taskcluster.net/v1/task/R3IWmOgoR4iQwNYcgcuGXA/runs/0/artifacts/public/build/de/target.installer.exe
en-CA https://queue.taskcluster.net/v1/task/Ypo7tfLjQ0SK-UrwgbOZKQ/runs/0/artifacts/public/build/en-CA/target.installer.exe
en-GB https://queue.taskcluster.net/v1/task/eBDR3anySlibD-5XEX5Arw/runs/0/artifacts/public/build/en-GB/target.installer.exe
fr https://queue.taskcluster.net/v1/task/BeGQbepaTLCDq8joE5cnBA/runs/0/artifacts/public/build/fr/target.installer.exe
it https://queue.taskcluster.net/v1/task/b_9XXeHHQrynA93reXYU-g/runs/0/artifacts/public/build/it/target.installer.exe

Mac builds:
de https://queue.taskcluster.net/v1/task/J3k3EZMrQxu3OMYggWLAog/runs/0/artifacts/public/build/de/target.dmg
en-CA https://queue.taskcluster.net/v1/task/G7fSObxKS7W81X6RqD0s_g/runs/0/artifacts/public/build/en-CA/target.dmg
en-GB https://queue.taskcluster.net/v1/task/G9nUItjTQbOhByZt4SYM-A/runs/0/artifacts/public/build/en-GB/target.dmg
fr https://queue.taskcluster.net/v1/task/EQLDul2XR9yNB-5CaaDbRg/runs/0/artifacts/public/build/fr/target.dmg
it https://queue.taskcluster.net/v1/task/Bzc0mmIRRzm7SgngyhXsfw/runs/0/artifacts/public/build/it/target.dmg

Linux builds:
de https://queue.taskcluster.net/v1/task/TgVtOQUtRe-3g15s7eMlQA/runs/0/artifacts/public/build/de/target.tar.bz2
en-CA https://queue.taskcluster.net/v1/task/IJV9MoT2S3asBD51sQ0vHw/runs/0/artifacts/public/build/en-CA/target.tar.bz2
en-GB https://queue.taskcluster.net/v1/task/IJV9MoT2S3asBD51sQ0vHw/runs/0/artifacts/public/build/en-GB/target.tar.bz2
fr https://queue.taskcluster.net/v1/task/TYHp3G2GSAy4F3vSs4Bo9A/runs/0/artifacts/public/build/fr/target.tar.bz2
it https://queue.taskcluster.net/v1/task/Fx5MgWT0QQuQhNm1mEe2GA/runs/0/artifacts/public/build/it/target.tar.bz2

Comment 10

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Sign off was sent as GREEN. Removing the ni? and marking as Verified - Fixed.