1550902 - Add minimum size to panes

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Derek]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.103 Safari/537.36

Steps to reproduce:

Set maxSize="70%" (previously set to 70% in horizontal mode and 95% in vertical mode which didn't make sense to me because what can you see with 5% of the window) to the initial SplitBox preventing either primary or secondary panes from becoming too small

Comment 1

[Derek]

Attachment: Change max size of Secondary and Editor panes r=davidwalsh

Set a maximum size for panes

Comment 2

[Derek]

Part of a set of changes from https://github.com/firefox-devtools/debugger/pull/8200 that David asked me to separate

Comment 3

[Liviu Seplecan]

Hi @Derek, I've tested your issue:
[Platform used]: Windows 10
[Firefox versions]: release 66.0.5 and latest nightly 68.0a1

On my end the issue cannot be reproduced. Please fell free to add more info's in order to figure it out how to reproduce the issue.
Thanks for your contribution.

Comment 4

[Derek]

Attachment: Current state of the debugger.

Breakpoints pane can take up 95% of the window space in horizontal mode which doesn't really make sense in the context of debugging (cannot even see code anymore).

Comment 5

[Derek]

Attachment: Max size of breakpoints pane after suggested change

After the change it won't be possible to increase the ratio of breakpoints pane to editor pane beyond this

Comment 6

[Derek]

Hey @Livlu,

We discussed adding a minimum size to the editor and secondary panes in this GitHub issue: https://github.com/firefox-devtools/debugger/issues/8127 (second comment).

I believe the change is necessary since having one of the panes take up to 95% of the window doesn't really make any sense in the context of debugging as you cannot see the code/breakpoints anymore.

Sorry my steps to reproduce were unclear.

Steps to reproduce:

1. Open debugger in vertical mode
2. Try to make breakpoints pane as large as you can (should completely take up the view port)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b820404d54be
Change max size of Secondary and Editor panes r=davidwalsh

Comment 8

[Liviu Seplecan]

Attachment: Console -Debugger resizing.png

Comment 9

[Liviu Seplecan]

Attachment: console debugging resizing.png

Comment 10

[Liviu Seplecan]

Hi @Derek, re-tested the issue but still cannot reproduce. I will add a screenshot to see how it looks on my end.
Additionally, when you make a screenshot please make it with entire zone, I mean the whole perspective not just a piece.
Thanks

Comment 11

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b820404d54be