Closed Bug 1550965 Opened 6 years ago Closed 5 years ago

[wpt-sync] Sync PR 16688 - [LayoutNG] Fix not to keep a copy of ellipsis style

Categories

(Core :: CSS Parsing and Computation, defect, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16688 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16688
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[LayoutNG] Fix not to keep a copy of ellipsis style

This patch stops keeping a copy of style for ellipsis, but to
compute from the containing block.

Because paint-only changes to the style do not re-create
fragments, keeping a copy of style fails to use the updated
styles.

This also reduces a pointer from NGPhysicalTextFragment.

Change-Id: If0ec637d51f4f7f93828ab331f1e911995d23fb4
Bug: 636993
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596791
Commit-Queue: Koji Ishii \<kojii@chromium.org>
Reviewed-by: Emil A Eklund \<eae@chromium.org>
Reviewed-by: Aleks Totic \<atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656926}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/3d2a11035692 [wpt PR 16688] - [LayoutNG] Fix not to keep a copy of ellipsis style, a=testonly

https://hg.mozilla.org/mozilla-central/rev/3d2a11035692

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.