Closed Bug 1550972 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 16662 - Check child_change instead of change for explicit inherit.

Categories

(Core :: CSS Transitions and Animations, defect, P4)

Product:
Core
Component:
CSS Transitions and Animations
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16662 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16662
Details from upstream follow.

Rune Lillesveen <futhark@chromium.org> wrote:

Check child_change instead of change for explicit inherit.

Additionally, re-ordered checks in ComputedStyle::ComputeDifference()
and removed the full ComputedStyle comparison which did extra
comparisons of inherited data.

Bug: 958393
Change-Id: Ib798a688cc27719417326d6b3a6e75ce3595fa50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594575
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Commit-Queue: Rune Lillesveen \<futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657180}

Component: web-platform-tests → CSS Transitions and Animations
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/05d90d3d8e5f
[wpt PR 16662] - Check child_change instead of change for explicit inherit., a=testonly

https://hg.mozilla.org/mozilla-central/rev/05d90d3d8e5f

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.