1550975 - [wpt-sync] Sync PR 16695 - Check for detached ArrayBuffers in WebUSB transfer functions

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 16695 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16695
Details from upstream follow.

Reilly Grant <[e-mail]> wrote:

Check for detached ArrayBuffers in WebUSB transfer functions

This change adds checks to verify that the ArrayBuffers passed to WebUSB
functions controlTransferOut(), isochronousTransferOut(), and
transferOut() have not been detached. If so then an InvalidStateError
is thrown.

While the previous behavior was safe from use-after-frees it silently
sent the USB device an empty buffer which would be difficult to debug.

Change-Id: I94249dd0097991b2b4933093ac85f50f0ccda7c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598048
Reviewed-by: Jeremy Roman \<[e-mail]>
Commit-Queue: Reilly Grant \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#657350}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=de80b99e7b6dc50e91577c02c0cd67ba0373fb62

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a18a34e5a28743175e99688de73adf3191d6ad17

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Failed to get results from try push

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/34d3015c4c23
[wpt PR 16695] - Check for detached ArrayBuffers in WebUSB transfer functions, a=testonly

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/34d3015c4c23