Closed Bug 1551004 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 16744 - Fall back to document as style root when in dom removal.

Categories

(Core :: DOM: Core & HTML, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16744 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16744
Details from upstream follow.

Rune Lillesveen <futhark@chromium.org> wrote:

Fall back to document as style root when in dom removal.

When we are marking nodes for style recalc or invalidation during dom
removal operations, isConnected is not necessarily up-to-date and we
ended up setting the new root to a node inside a subtree about to be
removed.

This reverts the way of fixing one of these issues in [1] and falls back
to using the Document node as the root when in dom removal to avoid
such issues.

[1] https://crrev.com/1a64b95651087efffb21e2046dcf5c0869a27849

Bug: 954892
Change-Id: I763a9bbd44efcd9beba711f145ea7f99b55fce6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602509
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Commit-Queue: Rune Lillesveen \<futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658100}

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/edcd385f70b0
[wpt PR 16744] - Fall back to document as style root when in dom removal., a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.