Closed Bug 1551025 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 16759 - MSE: Enable 'video/mp4' opus IsTypeSupported success

Categories

(Core :: Audio/Video: Playback, defect, P4)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16759 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16759
Details from upstream follow.

Matt Wolenetz <wolenetz@chromium.org> wrote:

MSE: Enable 'video/mp4' opus IsTypeSupported success

Previously, only 'audio/mp4' would report support for opus codec in
Chromium MSE. This change adds support for opus codec in 'video/mp4'
mime to Chromium. For example, MediaSource.IsTypeSupported('video/mp4;
codecs="opus"') now returns true with this change.

Also adds a couple opus-in-mp4 and -in-webm IsTypeSupported test cases
to the interop wpt suite, though the particular test file is currently
marked [ failure pass ] in Blink TestExpectations due to those tests
containing a mix of proprietary and non-proprietary codecs such that
bots running without all the necessary codec support will fail the test.
I've filed https://crbug.com/961443 to track improving MSE
IsTypeSupported test coverage at least in Chromium.

BUG=649438

Change-Id: I7c47b6c2566432be9627394f5ff30e0a43888300
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603527
Reviewed-by: Dan Sanders \<sandersd@chromium.org>
Commit-Queue: Matthew Wolenetz \<wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658339}

Component: web-platform-tests → Audio/Video: Playback
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8edfc096dca7
[wpt PR 16759] - MSE: Enable 'video/mp4' opus IsTypeSupported success, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8edfc096dca7

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.