Closed Bug 1551188 Opened 7 months ago Closed 7 months ago

Print listener address in a way that conforms with Chrome

Categories

(Remote Protocol :: Agent, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ato, Assigned: ato)

References

Details

Attachments

(1 file)

Puppeteer parses stderr looking for the regular expression
^DevTools listening on (ws:\/\/.*)$. For Puppeteer to be able
to connect to Firefox, we need to change the line we print slightly
to conform with this expression.

The remote agent also uses Log.jsm to print it, but we cannot rely
on logging always being enabled, e.g. if remote.log.level is set
to Warn or above. For this reason we should use dump().

The stderr issue is otherwise tracked in
https://bugzilla.mozilla.org/show_bug.cgi?id=1543115.

Assignee: nobody → ato
Blocks: 1543115, 1540655
Status: NEW → ASSIGNED
Priority: -- → P1

Puppeteer parses stderr looking for the regular expression
^DevTools listening on (ws://.*)$. For Puppeteer to be able
to connect to Firefox, we need to change the line we print slightly
to conform with this expression.

The remote agent also uses Log.jsm to print it, but we cannot rely
on logging always being enabled, e.g. if remote.log.level is set
to Warn or above. For this reason we should use dump().

The patch also instantiates the main target before starting the HTTPD.

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96e678846de7
remote: print listening address similarly to chrome; r=remote-protocol-reviewers,ochameau
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.