Closed Bug 1551196 Opened 5 years ago Closed 4 years ago

Editor not notifying every time there's no bound frame is not quite sound.

Categories

(Core :: DOM: Editor, defect, P3)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1401657

People

(Reporter: emilio, Unassigned)

References

Details

Attachments

(2 files, 1 obsolete file)

Editor has a bunch of places where it doesn't notify if mBoundFrame is null.

That's not generally sound, see the test-case, which changes the value while the element is display: none, and then changes display via the style attribute (so we don't re-selector-match).

See Also: → 1551086
Attached file More reliable test-case. (obsolete) —
Attachment #9064457 - Attachment is obsolete: true
Priority: -- → P3

So I gave a quick shot to always notify, and the cool thing is that it's almost-green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8003169c42e4a3f4eb6678204fc06511b5713b3

And there's even a new WPT that passes. The only orange is due to XBL being unsound as usual... Brian, is there any bug tracking the de-XBL of <textbox>? And I guess the URL bar as well?

Flags: needinfo?(bgrinstead)

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

And there's even a new WPT that passes. The only orange is due to XBL being unsound as usual... Brian, is there any bug tracking the de-XBL of <textbox>? And I guess the URL bar as well?

The metabug for textbox is Bug 1513325. Here's what we have left under that:

▶ textbox -> relies on another meta (bug 1547372) to go through and replace frontend callers with html:input.
▶▶ urlbar -> this is the quantumbar and used only for <content>. We have bug 1513337 to inline that into browser.xul once the old code is removed.
▶▶ autocomplete. This one is complex and we thought it was going to require some bigger changes, but ntim came up with a patch that mostly works using a customized Custom Element in bug 1534455.
▶▶▶ legacy-urlbar. This is the old URL bar, which will be removed in Bug 1551232.

Depends on: 1513325
Flags: needinfo?(bgrinstead)
See Also: → 1401657
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: