1551215 - The World Series of Poker Facebook game will not start

Status: RESOLVED DUPLICATE of bug 1551729

(Web Compatibility :: Site Reports, defect, P3)

Description

[Rares Doghi, Desktop QA]

Attachment: CookiesDisabled.png

[Affected versions]
Firefox 68.0a1

[Affected platforms]
Ubuntu 16.04, Windows 7/10, Mac OS 10.13

[Steps to reproduce]

1. Reach Facebook.com and Log in.
2. Reach the WSOP poker game and try to Play the game

[Expected result]
The Game should start without issues.

[Actual result]
The Cookies Disabled message is displayed.
As well as the Please ensure that your cookies are enabled and that they are not restricted in some way by your browser settings. message is also displayed.

Please note that the same issue occurs even if the user Turns of blocking for this site.

Comment 1

[Rares Doghi, Desktop QA]

Hi again, I tried to do a Mozregression but there were waay to many skipped builds I couldnt grab an accurate push log,but maybe someone can guess which caused the issue here:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bdf36faf780ba706bbebc8cbcd32ba892a899440&tochange=03166449953fbcaaf6c66d2c3b358319781a0e52

Comment 2

[Johann Hofmann [:johannh]]

Please note that the same issue occurs even if the user Turns of blocking for this site.

That seems quite weird to me and indicates an error in their detection code rather than our anti-tracking being at fault. Mike, should we move this over to webcompat?

Comment 3

[Mike Taylor [:miketaylr]]

Dennis, could you investigate here?

Comment 4

[Dennis Schubert [:denschub]]

Their cookie checks looks like this:

this.areCookiesEnabled = function() {
  const e = ~~(1e3 * Math.random()) + "" + Date.now();
  return (
    (!navigator.hasOwnProperty("cookieEnabled") || navigator.cookieEnabled) &&
    "cookie" in document &&
    (document.cookie.length > 0 || (document.cookie = e).indexOf.call(document.cookie, e) > -1)
  );
}

so they end up setting document.cookie to a random value like 8401557910195219. This is not supposed to work, as the value always should be a set-cookie string, so we discard it. Chrome, however, does create a new cookie with no name and a value. This has to be a bug, since this also results in the Cookie header on requests be in a wrong format, so I filed a bug.

To get this site working in all browsers, they should rewrite their test so that setting the value contains a cookie name as well, like document.cookie = "test=" + e. I don't think we should change anything on our side, unless we get feedback from Chrome people that they are not going to change their behavior.

Comment 5

[Mike Taylor [:miketaylr]]

Excellent diagnosis, thanks Dennis.

Comment 6

[(no longer active)]

Dupe of bug 1551729?

Comment 7

[Dennis Schubert [:denschub]]

Yes, absolutely.