1551218 - Enable ESLint and Prettier for the devtools debugger

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1551218 - Part 1: Enable running top-level eslint for the devtools debugger, r=standard8,jlast

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1551218 - Part 2: Remove devtools debugger eslint rules conflicting with any prettier configuration, r=standard8,jlast

Depends on D30926

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1551218 - Part 3: Add a top-level .prettierrc and reformat the debugger, r=standard8,jlast

Depends on D30927

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1551218 - Part 4: Manually reformat the debugger where autofix wasn't possible, r=standard8,jlast

Depends on D30928

Comment 5

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1551218 - Part 1: Enable running top-level eslint for the devtools debugger, r=standard8,jlast

Comment 7

[Victor Porof [:vporof][:vp]]

Try run was green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=311fa6c9fd75e8710f018525187ef28d8c7eaa7e

Patches r+ed.

This looks ready to go.

Comment 8

[Victor Porof [:vporof][:vp]]

Demo run showing try complaining about formatting: https://treeherder.mozilla.org/#/jobs?repo=try&revision=28af6b9fc2be72de85bd9a0c1f59130a42321bda

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8952fe75cb7a
Part 1: Enable running top-level eslint for the devtools debugger, r=Standard8,jlast

Comment 10

[Alexandru Michis [:malexandru]]

Backed out changeset 8952fe75cb7a for causing linting failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/c94c54aff4669f52cebc76ddad34a76f4fafd03b

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=8952fe75cb7a65e4f8d718439f6e156ed179c66f&selectedJob=247041014

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=247041014&repo=autoland&lineNumber=268

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edafe8d51cbf
Part 1: Enable running top-level eslint for the devtools debugger, r=Standard8,jlast
https://hg.mozilla.org/integration/autoland/rev/de264ab1edfb
Part 2: Remove devtools debugger eslint rules conflicting with any prettier configuration, r=Standard8,jlast
https://hg.mozilla.org/integration/autoland/rev/88358b362c57
Part 3: Add a top-level .prettierrc and reformat the debugger, r=jlast
https://hg.mozilla.org/integration/autoland/rev/43baeaf53869
Part 4: Manually reformat the debugger where autofix wasn't possible, r=jlast

Comment 12

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/edafe8d51cbf
https://hg.mozilla.org/mozilla-central/rev/de264ab1edfb
https://hg.mozilla.org/mozilla-central/rev/88358b362c57
https://hg.mozilla.org/mozilla-central/rev/43baeaf53869