Perma-failing [mozilla-release] services/common/tests/unit/test_uptake_telemetry.js | test_age_is_converted_to_string_and_reported - [test_age_is_converted_to_string_and_reported : 118] parent must be in snapshot. Has []. - false == true

RESOLVED FIXED in Firefox 67

Status

defect
P5
normal
RESOLVED FIXED
Last month
28 days ago

People

(Reporter: intermittent-bug-filer, Assigned: leplatrem)

Tracking

({intermittent-failure, regression})

unspecified
Firefox 68
Points:
---

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox67 fixed, firefox68 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

Last month
treeherder

Filed by: apavel [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=246197956&repo=mozilla-release
Full log: https://queue.taskcluster.net/v1/task/CrjEsRwsRDW9GVQBkJmH7Q/runs/0/artifacts/public/logs/live_backing.log


21:11:18 INFO - TEST-START | services/common/tests/unit/test_uptake_telemetry.js
21:11:18 WARNING - TEST-UNEXPECTED-FAIL | services/common/tests/unit/test_uptake_telemetry.js | xpcshell return code: 0
21:11:18 INFO - TEST-INFO took 257ms
21:11:18 INFO - >>>>>>>
21:11:18 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
21:11:18 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
21:11:18 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
21:11:18 INFO - running event loop
21:11:18 INFO - services/common/tests/unit/test_uptake_telemetry.js | Starting test_unknown_status_is_not_reported

21:11:18 INFO - TEST-PASS | services/common/tests/unit/test_uptake_telemetry.js | test_unknown_status_is_not_reported - [test_unknown_status_is_not_reported : 45] check events for custom_5_error - 0 == 0
21:11:18 INFO - (xpcshell/head.js) | test run_next_test 1 pending (2)
21:11:18 INFO - (xpcshell/head.js) | test test_unknown_status_is_not_reported finished (2)
21:11:18 INFO - "CONSOLE_MESSAGE: (error) [JavaScript Error: "Invalid string label"]"
21:11:18 INFO - services/common/tests/unit/test_uptake_telemetry.js | Starting test_age_is_converted_to_string_and_reported
21:11:18 INFO - (xpcshell/head.js) | test test_age_is_converted_to_string_and_reported pending (2)
21:11:18 INFO - (xpcshell/head.js) | test run_next_test 1 finished (2)
21:11:18 WARNING - TEST-UNEXPECTED-FAIL | services/common/tests/unit/test_uptake_telemetry.js | test_age_is_converted_to_string_and_reported - [test_age_is_converted_to_string_and_reported : 118] parent must be in snapshot. Has []. - false == true
21:11:18 INFO - resource://testing-common/TelemetryTestUtils.jsm:assertEvents:118
21:11:18 INFO - Z:/task_1557776783/build/tests/xpcshell/tests/services/common/tests/unit/test_uptake_telemetry.js:test_age_is_converted_to_string_and_reported:54
21:11:18 INFO - Z:\task_1557776783\build\tests\xpcshell\head.js:_do_main:224
21:11:18 INFO - Z:\task_1557776783\build\tests\xpcshell\head.js:_execute_test:526
21:11:18 INFO - -e:null:1
21:11:18 INFO - exiting test
21:11:18 INFO - Unexpected exception NS_ERROR_ABORT:
21:11:18 INFO - _abort_failed_test@Z:\task_1557776783\build\tests\xpcshell\head.js:739:20
21:11:18 INFO - do_report_result@Z:\task_1557776783\build\tests\xpcshell\head.js:846:5
21:11:18 INFO - Assert<@Z:\task_1557776783\build\tests\xpcshell\head.js:54:5
21:11:18 INFO - proto.report@resource://testing-common/Assert.jsm:213:10
21:11:18 INFO - proto.ok@resource://testing-common/Assert.jsm:233:10
21:11:18 INFO - assertEvents@resource://testing-common/TelemetryTestUtils.jsm:118:12
21:11:18 INFO - test_age_is_converted_to_string_and_reported@Z:/task_1557776783/build/tests/xpcshell/tests/services/common/tests/unit/test_uptake_telemetry.js:54:22
21:11:18 INFO - _do_main@Z:\task_1557776783\build\tests\xpcshell\head.js:224:6
21:11:18 INFO - _execute_test@Z:\task_1557776783\build\tests\xpcshell\head.js:526:5
21:11:18 INFO - @-e:1:1
21:11:18 INFO - exiting test
21:11:18 INFO - <<<<<<<

Mathieu, this appears to be from https://hg.mozilla.org/releases/mozilla-beta/rev/f9c39d67b0d6#l1.24 and it's failing only on xpcshell nightly opt platforms, please take a look.

Disabled the test in the meantime here: https://hg.mozilla.org/releases/mozilla-release/rev/bcfe2b750b1df6e2e869beba2ee10a06ff6f6d9a

Flags: needinfo?(mathieu)

"Nightly" is a misnomer here. These builds are the ones which will get promoted as release builds eventually (i.e. update channel = "release"). So from what I can see, this probably goes back to the condition here:
https://hg.mozilla.org/releases/mozilla-release/file/f9c39d67b0d6c8b192af593ed98e8ae71f567734/services/common/uptake-telemetry.js#l162

Where we're explicitly altering the behavior if the update channel is release or esr. Which also explains why debug builds aren't failing - those are built with "default" as the update channel.

So basically I think this boils down to the subtest in question making assumptions which don't hold true for release builds.

Assignee

Comment 4

Last month

Thanks for the precisions. I could reproduce locally by forcing the channel to release indeed. Good catch!

The patch on the way! I set you as a reviewer in case this blocks you.

Assignee: nobody → mathieu
Flags: needinfo?(mathieu)

Comment 5

Last month
Pushed by mleplatre@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1d7e8c0d4f71
Fix Uptake Telemetry test failure if channel is release r=glasserc

Comment 6

Last month
bugherder
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Comment hidden (Intermittent Failures Robot)
You need to log in before you can comment on or make changes to this bug.