Cleanup readability of LoginAutoCompleteResult

RESOLVED FIXED in Firefox 69

Status

()

task
P2
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: MattN, Assigned: MattN)

Tracking

Trunk
mozilla69
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox69 fixed)

Details

(Whiteboard: [passwords:tech-debt])

Attachments

(8 attachments)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

The constructor and the get*At methods are way too complicated and need to be cleaned up before we build more atop it like password generation.

Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/00df22944d9a
Improve readability of LoginAutoCompleteResult. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/c74ca2406a0d
Move string utilities to the top-level of LoginAutoCompleteResult.jsm. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/a737c603ae33
Make a class for each style of login autocomplete item. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/ce3d6217e796
Read login autocomplete labels from the AutocompleteItem instance. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/dafc626c6590
Read login autocomplete values from the AutocompleteItem instance. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/801ff26b3c1d
Read login autocomplete comments from the AutocompleteItem instance. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/289880efd193
Delete login autocomplete rows using the AutocompleteItem instance. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/9cf745b75ebc
Move LoginAutoCompleteResult ctr. variables closer to their use and cleanup cruft. r=sfoster
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.