Closed
Bug 1551407
Opened 5 years ago
Closed 5 years ago
Cleanup readability of LoginAutoCompleteResult
Categories
(Toolkit :: Password Manager, task, P2)
Toolkit
Password Manager
Tracking
()
RESOLVED
FIXED
mozilla69
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: MattN, Assigned: MattN)
References
Details
(Whiteboard: [passwords:tech-debt])
Attachments
(8 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
The constructor and the get*At methods are way too complicated and need to be cleaned up before we build more atop it like password generation.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D31028
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D31029
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D31030
|
|
Assignee | |
Comment 5•5 years ago
|
||
Depends on D31031
|
|
Assignee | |
Comment 6•5 years ago
|
||
Depends on D31032
|
|
Assignee | |
Comment 7•5 years ago
|
||
Depends on D31033
|
|
Assignee | |
Comment 8•5 years ago
|
||
Depends on D31034
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/00df22944d9a Improve readability of LoginAutoCompleteResult. r=sfoster https://hg.mozilla.org/integration/autoland/rev/c74ca2406a0d Move string utilities to the top-level of LoginAutoCompleteResult.jsm. r=sfoster https://hg.mozilla.org/integration/autoland/rev/a737c603ae33 Make a class for each style of login autocomplete item. r=sfoster https://hg.mozilla.org/integration/autoland/rev/ce3d6217e796 Read login autocomplete labels from the AutocompleteItem instance. r=sfoster https://hg.mozilla.org/integration/autoland/rev/dafc626c6590 Read login autocomplete values from the AutocompleteItem instance. r=sfoster https://hg.mozilla.org/integration/autoland/rev/801ff26b3c1d Read login autocomplete comments from the AutocompleteItem instance. r=sfoster https://hg.mozilla.org/integration/autoland/rev/289880efd193 Delete login autocomplete rows using the AutocompleteItem instance. r=sfoster https://hg.mozilla.org/integration/autoland/rev/9cf745b75ebc Move LoginAutoCompleteResult ctr. variables closer to their use and cleanup cruft. r=sfoster
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/00df22944d9a
https://hg.mozilla.org/mozilla-central/rev/c74ca2406a0d
https://hg.mozilla.org/mozilla-central/rev/a737c603ae33
https://hg.mozilla.org/mozilla-central/rev/ce3d6217e796
https://hg.mozilla.org/mozilla-central/rev/dafc626c6590
https://hg.mozilla.org/mozilla-central/rev/801ff26b3c1d
https://hg.mozilla.org/mozilla-central/rev/289880efd193
https://hg.mozilla.org/mozilla-central/rev/9cf745b75ebc
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
|
|
Assignee | |
Updated•5 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•