1551407 - Cleanup readability of LoginAutoCompleteResult

Status: RESOLVED FIXED

(Toolkit :: Password Manager, task, P2)

Description

[Matthew N. [:MattN]]

The constructor and the get*At methods are way too complicated and need to be cleaned up before we build more atop it like password generation.

Comment 1

[Matthew N. [:MattN]]

Attachment: Bug 1551407 - Improve readability of LoginAutoCompleteResult. r=sfoster

Comment 2

[Matthew N. [:MattN]]

Attachment: Bug 1551407 - Move string utilities to the top-level of LoginAutoCompleteResult.jsm. r=sfoster

Depends on D31028

Comment 3

[Matthew N. [:MattN]]

Attachment: Bug 1551407 - Make a class for each style of login autocomplete item. r=sfoster

Depends on D31029

Comment 4

[Matthew N. [:MattN]]

Attachment: Bug 1551407 - Read login autocomplete labels from the AutocompleteItem instance. r=sfoster

Depends on D31030

Comment 5

[Matthew N. [:MattN]]

Attachment: Bug 1551407 - Read login autocomplete values from the AutocompleteItem instance. r=sfoster

Depends on D31031

Comment 6

[Matthew N. [:MattN]]

Attachment: Bug 1551407 - Read login autocomplete comments from the AutocompleteItem instance. r=sfoster

Depends on D31032

Comment 7

[Matthew N. [:MattN]]

Attachment: Bug 1551407 - Delete login autocomplete rows using the AutocompleteItem instance. r=sfoster

Depends on D31033

Comment 8

[Matthew N. [:MattN]]

Attachment: Bug 1551407 - Move LoginAutoCompleteResult ctr. variables closer to their use and cleanup cruft. r=sfoster

Depends on D31034

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00df22944d9a
Improve readability of LoginAutoCompleteResult. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/c74ca2406a0d
Move string utilities to the top-level of LoginAutoCompleteResult.jsm. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/a737c603ae33
Make a class for each style of login autocomplete item. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/ce3d6217e796
Read login autocomplete labels from the AutocompleteItem instance. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/dafc626c6590
Read login autocomplete values from the AutocompleteItem instance. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/801ff26b3c1d
Read login autocomplete comments from the AutocompleteItem instance. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/289880efd193
Delete login autocomplete rows using the AutocompleteItem instance. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/9cf745b75ebc
Move LoginAutoCompleteResult ctr. variables closer to their use and cleanup cruft. r=sfoster

Comment 10

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/00df22944d9a
https://hg.mozilla.org/mozilla-central/rev/c74ca2406a0d
https://hg.mozilla.org/mozilla-central/rev/a737c603ae33
https://hg.mozilla.org/mozilla-central/rev/ce3d6217e796
https://hg.mozilla.org/mozilla-central/rev/dafc626c6590
https://hg.mozilla.org/mozilla-central/rev/801ff26b3c1d
https://hg.mozilla.org/mozilla-central/rev/289880efd193
https://hg.mozilla.org/mozilla-central/rev/9cf745b75ebc